DefaultReactiveHashOperations.readHashValue might return null [DATAREDIS-1161]

[spring-projects-issues]

Oskar Olsson opened DATAREDIS-1161 and commented

This issue can be closed as the scenario I considered is not valid one. As mentioned in the comment, if the arg would be null the map would not be triggered. Returning null in this case should be fine as that scenario should not happen anyway.

-readHashValue in DefaultReactiveHashOperations returns null if passed as argument.-
-Since it is used in a map operator for get, null will result in following error:-
-java.lang.NullPointerException: The mapper returned a null value.-

-Possibly it would be better to return an empty mono in this case, unless there is a more standard way of handling this scenario.- 

---

Affects: 2.2.7 (Moore SR7)

Referenced from: pull request #538

Backported to: 2.3.1 (Neumann SR1), 2.2.8 (Moore SR8), 2.1.18 (Lovelace SR18)

[spring-projects-issues]

Oskar Olsson commented

After some consideration, this might not be an issue for the scenario described here.
If the Mono was empty (null), the map operator should not have triggered at all and readHashValue would not be executed. 
Will look into this a bit more and close the issue if I can't verify the root cause of this error

[spring-projects-issues]

Mark Paluch commented

Since the code was wrong in that place, we decided to fix it