@ControllerAdvice behaving erratically in latest milestones [SPR-15861]

[spring-projects-issues]

Alex opened SPR-15861 and commented

I'm using messaging (websocket) classes with methods annotated with @MessageMapping, with Spring Boot 2.0M3 and I'm experiencing stability issues: my class marked with @ControllerAdvice sometimes is not handling the exceptions and they are instead propagated to the client.

I've also seen the problem where when one Exception is generated by controller A gets correctly handled by the @ControllerAdvice class, while when generated by controller B is not.

This seems to be related to the way the binary is built: some builds works fine, while some others exhibit the problem, so I would suppose that a different ordering of the jars inside the artifact causes the problem.

I'm not able to reproduce it at will right now, sometimes it works, sometimes not, I would like to leave this report open to track the problem and see if someone else runs in it too.

---

Affects: 5.0 RC3

Issue Links:

• ExceptionHandlerMethodResolver loses all handler methods [SPR-15907] #20461 ExceptionHandlerMethodResolver loses all handler methods ("duplicates")

[spring-projects-issues]

Rossen Stoyanchev commented

I can't think of any recent changes to nether @ControllerAdvice ordering nor exception handler resolution.

At startup you should see INFO messages such as "Detected @MessageExceptionHandler methods in ... ". You can check what that looks like when the problem occurs. That could help prove a problem of ordering vs a problem of resolving exception handlers.

You can try changing the Spring Framework vs Spring Boot versions independently to determine if the problem is Spring Framework or Spring Boot related and also narrowing the version down could help a lot.

[spring-projects-issues]

Alex commented

I'm still testing, but at a first glance it seems like it's due to Boot 2M3 and not Spring 5RC3.
I.e.: using boot 2M2 with spring 5rc3 seems to work fine, so maybe it's some updated dependencies in boot2M3

[spring-projects-issues]

Alex commented

I was wrong: the problem happens even setting Spring 5 RC3 with boot 2 M2.

[spring-projects-issues]

Rossen Stoyanchev commented

I would first try to determine in what version of Boot did it start failing. Then keep Boot at the last version before it started failing and try changing up the Spring Framework version. Or vice versa keep Spring Framework at the last version before it started failing and change up the Boot version.

Otherwise we would need a sample to demonstrate the issue.

[spring-projects-issues]

Alex commented

Sorry, I was not so clear in my last message, I try again.

Spring Boot 2M2 works fine for me, M3 does not.

So I used Boot 2M2 by hand-selecting Spring 5RC3 in maven and reproduced the issue.

[spring-projects-issues]

Rossen Stoyanchev commented

Okay I see. Can you provide some indication of how to reproduce? Actual sample would be best.

[spring-projects-issues]

Alex commented

I'm sorry I'm unable to provide sources (it's a big, internal application), but it uses a few @MessagingController and @RestController and one @ControllerAdvice which handles all the exceptions (for both messaging and rest controllers), encapsulates them and send them in a form understandable to the clients.

When the @ControllerAdvice does not work, the client waits fir a reply that is never coming.

[spring-projects-issues]

Rossen Stoyanchev commented

I'm not asking for the entire application of course but some more specific guidance at least. Basically I would have to create some sample myself in an attempt to reproduce the issue. However I can only guess what exactly to try. So I'm asking you to take that first step and if it is easy (and it's Boot after all), then pass it on. If it's not easy then I'm not sure how I could reproduce it.

[spring-projects-issues]

Alex commented

I can try to make a minimal app, the problem is that the behaviour seems inconsistent and not deterministic...

[spring-projects-issues]

Lu Fangjian commented

I am also facing the same issue which I have been trying for this entire week to narrow down the cause, but no luck yet. I have described it here.

[spring-projects-issues]

Lu Fangjian commented

@Alex I guess it can be related to #20461.

[spring-projects-issues]

Alex commented

Wow, that seems the problem, indeed!
Thanks Fangjian for the link, and thanks Juergen for the fix!

The bug can be closed now?