SubProtocolWebSocketHandler should not log ERROR on "No messages received after ..." [SPR-16409]

[spring-projects-issues]

Stefan Norberg opened SPR-16409 and commented

SubProtocolWebSocketHandler log level seems off for:

spring-framework/spring-websocket/src/main/java/org/springframework/web/socket/messaging/SubProtocolWebSocketHandler.java

Line 473 in 4b861ae

logger.error("No messages received after " + timeSinceCreated + " ms. " +

I feel that this log message should be logged on INFO (or possibly WARN) rather than ERROR:

ERROR o.s.w.s.m.SubProtocolWebSocketHandler - No messages received after 102078 ms. Closing WebSocketServerSockJsSession[id=m5sjshh2]

---

Affects: 4.3.14, 5.0 GA

Reference URL:

spring-framework/spring-websocket/src/main/java/org/springframework/web/socket/messaging/SubProtocolWebSocketHandler.java

Line 473 in 4b861ae

logger.error("No messages received after " + timeSinceCreated + " ms. " +

Issue Links:

• Deadlock in SubProtocolWebSocketHandler on shutdown with Undertow [SPR-16488] #21031 Deadlock in SubProtocolWebSocketHandler on shutdown with Undertow
• AbstractClientSockJsSession.close call does not propagate IOException from disconnect [SPR-16415] #20961 AbstractClientSockJsSession.close call does not propagate IOException from disconnect

Referenced from: commits 8e2be91, 09cb7f4

Backported to: 4.3.15

[spring-projects-issues]

Stefan Norberg commented

Also, StandardWebSocketHandlerAdapter will log an error when client disconnects.

[spring-projects-issues]

Juergen Hoeller commented

I've fine-tuned our logging of WebSocket close exceptions in all applicable decorators, consistently logging close exceptions at WARN level instead of ERROR, and lowered the log level of the "No message" part to INFO (as you suggested).

[spring-projects-issues]

Stefan Norberg commented

Awesome. Thank you!