-
Notifications
You must be signed in to change notification settings - Fork 38.6k
Closed
Labels
in: testIssues in the test moduleIssues in the test moduletype: enhancementA general enhancementA general enhancement
Milestone
Description
The enum constants in BeanOverrideStrategy
reflect our initial understanding of how the Bean Override feature would work; however, we no longer create or replace BeanDefinitions
in general.
We only create a BeanDefinition
when the user has requested to override a bean that doesn't exist, and we never replace a BeanDefinition
.
Furthermore, the Bean Override feature is not limited to beans that have a BeanDefinition
. On the contrary, we actually support overrides for manually registered singletons.
In light of the above, we should rename the enum constants in BeanOverrideStrategy
and revise the documentation (Javadoc and reference manual).
I recommend the following renaming.
REPLACE_DEFINITION
→REPLACE
REPLACE_OR_CREATE_DEFINITION
→REPLACE_OR_CREATE
WRAP_BEAN
→WRAP
simonbasle
Metadata
Metadata
Assignees
Labels
in: testIssues in the test moduleIssues in the test moduletype: enhancementA general enhancementA general enhancement