500 response for ResourceHttpRequestHandler when requested range is not satisfied

[NielsCW]

When sending a request to a resource with an invalid range, the server responds with a 500 Internal server error instead of 416 Requested range not satisfiable.

When the ResourceHttpRequestHandler is executed with an invalid range then it will call the HttpServletResponse.sendError(HttpServletResponse.SC_REQUESTED_RANGE_NOT_SATISFIABLE) method:

spring-framework/spring-webmvc/src/main/java/org/springframework/web/servlet/resource/ResourceHttpRequestHandler.java

Lines 578 to 581 in 75329e6

	catch (IllegalArgumentException ex) {
	response.setHeader(HttpHeaders.CONTENT_RANGE, "bytes */" + resource.contentLength());
	response.sendError(HttpServletResponse.SC_REQUESTED_RANGE_NOT_SATISFIABLE);
	}

Further down the processing line this will not result in a ProblemDetail body response, so the writeWithMessageConverters method in AbstractMessageConverterMethodProcessor will throw a HttpMessageNotWritableException from:

spring-framework/spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/method/annotation/AbstractMessageConverterMethodProcessor.java

Lines 364 to 367 in 8b14bf8

	if (isContentTypePreset || !CollectionUtils.isEmpty(producibleMediaTypes)) {
	throw new HttpMessageNotWritableException(
	"No converter for [" + valueType + "] with preset Content-Type '" + contentType + "'");
	}

(Where valueType is java.util.LinkedHashMap and contentType is multipart/form-data)

[NielsCW]

An example that uses spring-content containing a WebTestClient test that reproduces the issue demo-api.zip

EDIT: Please use iss-34490.zip

[rstoyanchev]

The demo project is missing the (Gradle) build file. Could you provide that as well?

[NielsCW]

Sure, here is the updated demo-api.zip

[rstoyanchev]

There is still no build file in the zip.

[NielsCW]

The first one did indeed not contain a build.gradle file, here is a renamed version of the second zip with build.gradle to avoid confusion:

iss-34490.zip