Skip to content

Move Servlet-specific observation classes to dedicated package #29324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Move Servlet-specific observation classes to dedicated package #29324

wants to merge 1 commit into from

Conversation

izeye
Copy link
Contributor

@izeye izeye commented Oct 15, 2022

This PR moves Servlet-specific observation classes to a dedicated package as they seem to have been placed there accidentally.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 15, 2022
@bclozel bclozel self-assigned this Oct 15, 2022
@bclozel bclozel added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Oct 17, 2022
@bclozel bclozel added this to the 6.0.0-RC2 milestone Oct 17, 2022
@bclozel bclozel mentioned this pull request Oct 17, 2022
Closed
@bclozel bclozel added the status: declined A suggestion or change that we don't feel we should currently apply label Oct 17, 2022
@bclozel bclozel removed this from the 6.0.0-RC2 milestone Oct 17, 2022
@bclozel
Copy link
Member

bclozel commented Oct 17, 2022

Thanks a lot @izeye for the PR, this triggered an extensive review from the team and we decided to reorganize things more. I'm closing this PR in favor of #29334

@bclozel bclozel closed this Oct 17, 2022
@izeye izeye deleted the servlet branch October 17, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bclozel bclozel

Labels
status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izeye @bclozel @spring-projects-issues