Add ability for a user to set mqtt's quiescentTimeout for forceable shutdowns
#10210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cppwfs
commented
Jul 18, 2025
cppwfs
commented
- Mqttv5 updated to also support this feature
- Fixes: MQTT: Configure quiesceTimeout in disconnectForcibly() #10095
artembilan
requested changes
Jul 18, 2025
...va/org/springframework/integration/mqtt/inbound/AbstractMqttMessageDrivenChannelAdapter.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/integration/mqtt/inbound/AbstractMqttMessageDrivenChannelAdapter.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/integration/mqtt/inbound/AbstractMqttMessageDrivenChannelAdapter.java
Outdated
Show resolved
Hide resolved
...egration-mqtt/src/test/java/org/springframework/integration/mqtt/BackToBackAdapterTests.java
Outdated
Show resolved
Hide resolved
...tegration-mqtt/src/test/java/org/springframework/integration/mqtt/Mqttv5BackToBackTests.java
Outdated
Show resolved
Hide resolved
… shutdowns Mqttv5 updated to also support this feature Fixes: spring-projects#10095
Update tests to set setDisconnectCompletionTimeout and setQuiescentTimeout to 1L to reduce test runtime Rebase
cppwfs
force-pushed
the
mqtt-paho-add-quiesceTimeout
branch
from
4dfbf2a to
03d3bfd
Compare
artembilan
requested changes
Jul 18, 2025
...java/org/springframework/integration/mqtt/inbound/Mqttv5PahoMessageDrivenChannelAdapter.java
Outdated
Show resolved
Hide resolved
...egration-mqtt/src/test/java/org/springframework/integration/mqtt/BackToBackAdapterTests.java
Outdated
Show resolved
Hide resolved
… getQuiescentTimeout for quiescent timeout BackToBackAdapterTests initializeInboundAdapter needs to be a static method
|
Thanks. |
Add the quiescentTimeout in the disconnectForcibly in the Mqttv3ClientManager and Mqttv5ClientManager classes Add documentation to what's new doc describing the addition of quiescence timeout
artembilan
requested changes
Jul 18, 2025
It should be rewritten to state that this is exposing more of the MQTT Client API.
artembilan
requested changes
Jul 21, 2025
artembilan
requested changes
Jul 21, 2025
There was a problem hiding this comment.
Looks like PR build is failing in the test related to the change.
> Task :spring-integration-mqtt:test
ClientManagerBackToBackTests > testSameV3ClientIdWorksForPubAndSub() FAILED
java.lang.AssertionError at ClientManagerBackToBackTests.java:132
Any thoughts?
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.