GH-2762: Fix Topic Check with Consumer Overrides #2763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves spring-projects#2762 When checking for missing topics, the admin was created with the raw consumer factory properties and did not apply any overriding consumer properties in the `ContainerProperties`. Apply the overrides before creating the admin. Pull up a method that merges default properties (if any) because we have to iterate over the hash table because the user might have used `put()` instead of `setProperty()` to set properties. **cherry-pick to 2.9.x**
artembilan
requested changes
Aug 3, 2023
| * | ||
| */ | ||
| @EmbeddedKafka(topics = "mtccac") | ||
| public class MissingTopicCheckOverrideAdminConfig { |
There was a problem hiding this comment.
Is it intentional do not use a *Tests suffix?
artembilan
requested changes
Aug 3, 2023
| * | ||
| */ | ||
| @EmbeddedKafka(topics = "mtccac") | ||
| public class MissingTopicCheckOverrideAdminConfig { |
There was a problem hiding this comment.
/home/runner/work/spring-kafka/spring-kafka/spring-kafka/src/test/java/org/springframework/kafka/listener/MissingTopicCheckOverrideAdminConfigTests.java:46: error: class MissingTopicCheckOverrideAdminConfig is public, should be declared in a file named MissingTopicCheckOverrideAdminConfig.java
public class MissingTopicCheckOverrideAdminConfig {
There was a problem hiding this comment.
That's weird; it is correct locally.
|
... and cherry-picked to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2762
When checking for missing topics, the admin was created with the raw consumer factory properties and did not apply any overriding consumer properties in the
ContainerProperties.Apply the overrides before creating the admin.
Pull up a method that merges default properties (if any) because we have to iterate over the hash table because the user might have used
put()instead ofsetProperty()to set properties.cherry-pick to 2.9.x