-
-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Support for fault-tolerant execution #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dervoeti
wants to merge
19
commits into
main
Choose a base branch
from
feat/fault-tolerant-execution
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernauer
reviewed
Aug 5, 2025
4cc640f
to
3d113df
Compare
fc684e3
to
85a09cc
Compare
sbernauer
reviewed
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dropped some comments on the CRD code and YAML.
As an possible alternative I can propose a complex enum style, where we can together think about it, just pasting it here for reference for now
spec:
clusterConfig:
faultTolerantExecution:
query:
retryAttempts: 4 # maps to query-retry-attempts
retryInitialDelay: 10s
retryMaxDelay: 60s
retryDelayScaleFactor: 2.0 # f32
exchangeManager: # Optional
deduplicationBufferSize: 64Mi # Quantity
encryptionEnabled: true
sinkBufferPoolMinSize: 20
sinkBuffersPerPartition: 4
sinkMaxFileSize: 2Gi # Quantity
sourceConcurrentReaders: 8
s3:
baseDirectories:
- s3://trino-exchange-bucket/spooling
connection: # Mandatory
reference: minio-connection
maxErrorRetries: 10
uploadPartSize: 10Mi # Quantity
# OR
task:
retryAttemptsPerTask: 4 # maps to task-retry-attempts-per-task
retryInitialDelay: 10s
retryMaxDelay: 60s
retryDelayScaleFactor: 2.0 # f32
exchangeManager: # Mandatory
# ... same struct as above
docs/modules/trino/pages/usage-guide/fault-tolerant-execution.adoc
Outdated
Show resolved
Hide resolved
docs/modules/trino/pages/usage-guide/fault-tolerant-execution.adoc
Outdated
Show resolved
Hide resolved
docs/modules/trino/pages/usage-guide/fault-tolerant-execution.adoc
Outdated
Show resolved
Hide resolved
docs/modules/trino/pages/usage-guide/fault-tolerant-execution.adoc
Outdated
Show resolved
Hide resolved
tests/templates/kuttl/fault-tolerant-execution/helm-bitnami-minio-values.yaml
Outdated
Show resolved
Hide resolved
2567920
to
843b18d
Compare
sbernauer
reviewed
Aug 12, 2025
…adoc Co-authored-by: Sebastian Bernauer <[email protected]>
fd42c2b
to
af39e6b
Compare
3 tasks
eaaff12
to
9e587d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation for #576
When providing credentials for S3, Azure or GCS we currently need a
SecretClass
. It would be easier if the user could just provide aSecret
as an alternative, we had that discussion recently. To be consistent with the current state, I usedSecretClass
exclusively for now.Things I did not do in this PR to ease the review process (we could tackle those as a separate PR):
load_env_from_files
stuntDefinition of Done Checklist
Author
Reviewer
Acceptance
type/deprecation
label & add to the deprecation scheduletype/experimental
label & add to the experimental features tracker