Support Let's Encrypt for Open OnDemand #714
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priteau
force-pushed
the
lets-encrypt-ood
branch
from
c346577 to
2136629
Compare
priteau
force-pushed
the
lets-encrypt-ood
branch
4 times, most recently
from
a85f8da to
ffeafae
Compare
priteau
force-pushed
the
lets-encrypt-ood
branch
from
ffeafae to
ccafe06
Compare
sjpb
reviewed
Aug 6, 2025
|
|
||
| Alternatively, you can generate a certificate from Let's Encrypt automatically by configuring the following variables: | ||
| - `openondemand_certbot`: Optional. Default is false. Set to true to request a certificate from Let's Encrypt. | ||
| - `openondemand_certbot_email`: Optional. Default is empty. Set to the admin email address if using Let's Encrypt. |
There was a problem hiding this comment.
Does the domain for this have to match e.g. the cluster_domain_suffix or anything?
sjpb
reviewed
Aug 6, 2025
| - name: Open OnDemand certbot | ||
| import_role: | ||
| name: openondemand | ||
| tasks_from: certbot.yml |
There was a problem hiding this comment.
This seems to actually generate the LE cert? But this task is part of image build - how can that work? I'd have expected to only install the certbot package during image build, then run it during site.yml - what am I missing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.