-
-
Notifications
You must be signed in to change notification settings - Fork 860
Labels
BugSomething isn't working.Something isn't working.CIIssue or pull request specific to continuous integration environments.Issue or pull request specific to continuous integration environments.
Description
Description
In https://github.com/stdlib-js/stdlib/actions/runs/8496433869/job/23273812132?pr=1680, I noticed that not all tests were running. As can be observed in #1680, we have tests in nested directories. Locally, these tests were failing, but CI did not catch. The reason for this is that CI only attempts to run tests at the top-level of the test
folder within a package.
Line which needs to be updated:
files=$(find ${directories} -maxdepth 2 -wholename '**/test/test*.js' | grep -v '/fixtures/' | sort -u | tr '\n' ' ') || true |
Related Issues
No.
Questions
- What was the rationale for limiting test filtering to the top-level test directory? Why were nested tests ignored?
Demo
No response
Reproduction
- See feat: add support for auto-closing brackets/quotations in the REPL #1680 for an example test folder setup.
Expected Results
No response
Actual Results
No response
Version
No response
Environments
Node.js
Browser Version
No response
Node.js / npm Version
No response
Platform
No response
Checklist
- Read and understood the Code of Conduct.
- Searched for existing issues and pull requests.
Metadata
Metadata
Assignees
Labels
BugSomething isn't working.Something isn't working.CIIssue or pull request specific to continuous integration environments.Issue or pull request specific to continuous integration environments.