feat: add bracketed-paste mode in the REPL #2502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Snehil Shah <[email protected]>
Snehil-Shah
added
Enhancement
Signed-off-by: Snehil Shah <[email protected]>
kgryte
reviewed
Jul 3, 2024
kgryte
reviewed
Jul 3, 2024
Signed-off-by: Snehil Shah <[email protected]>
Signed-off-by: Snehil Shah <[email protected]>
Signed-off-by: Snehil Shah <[email protected]>
kgryte
reviewed
Jul 5, 2024
kgryte
reviewed
Jul 5, 2024
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Jul 5, 2024
kgryte
reviewed
Jul 5, 2024
kgryte
reviewed
Jul 5, 2024
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Jul 5, 2024
|
Aside: this PR is quite nice, as it is a big win to be able to copy and paste multi-line content into the REPL. So thank you for working on this. |
|
@kgryte I was thinking if it would make sense to disable auto close pairs during the pasting process? I noticed that pasting feels slow and it might also interfere if the user is not pasting syntactically correct code? |
|
@Snehil-Shah That makes sense. |
|
Whenever a user pastes content, what gets pasted should match verbatim the original content. |
Signed-off-by: Snehil Shah <[email protected]>
Signed-off-by: Snehil Shah <[email protected]>
|
@kgryte Done. Whatever the user pastes is preserved including TAB indentations. |
Signed-off-by: Snehil Shah <[email protected]>
kgryte
reviewed
Jul 5, 2024
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Jul 5, 2024
Signed-off-by: Athan <[email protected]>
kgryte
reviewed
Jul 5, 2024
Signed-off-by: Athan <[email protected]>
1 task
kgryte
pushed a commit
that referenced
this pull request
Jul 5, 2024
Addresses a test regression introduced in #2502. PR-URL: #2516 Ref: #2502 Ref: 7ba179c Reviewed-by: Athan Reines <[email protected]> Signed-off-by: Snehil Shah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2068
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers