fix: Properly handle prompt=None & avoid agent hanging #643
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zastrowm
commented
Aug 8, 2025
| "hatch fmt --formatter", | ||
| "hatch fmt --linter", |
There was a problem hiding this comment.
I want formatting to be first before linting, so I moved this up
zastrowm
force-pushed
the
fix_agent_hang
branch
from
5f6f85f to
3ad53b6
Compare
zastrowm
commented
Aug 8, 2025
| logger.debug("formatting request") | ||
| request = self.format_request(messages, tool_specs, system_prompt) | ||
| logger.debug("request=<%s>", request) | ||
| try: |
There was a problem hiding this comment.
This was the cause of the hang - since an exception was being thrown here and the queue never had anything in it:
sdk-python/src/strands/models/bedrock.py
Line 391 in 8b1de4d
dbschmigelski
previously approved these changes
Aug 11, 2025
Previously (strands-agents#642) bedrock would hang during message conversion because the exception was not being caught and thus the queue was always empty. Now all exceptions during conversion are caught
zastrowm
force-pushed
the
fix_agent_hang
branch
from
73ca87f to
b47b675
Compare
dbschmigelski
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid hanging when
prompt=Noneis passed into Agent - catch all exceptionsBedrockModel._streamso that theawait queue.get()always completessdk-python/src/strands/models/bedrock.py
Line 391 in 8b1de4d
Revisions
Related Issues
#642
Documentation PR
N/A
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.