-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update Strapi Cloud settings screenshots #2585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all these screenshot updates, @mariekirsch!
Unless I missed something 🤔 I believe the assets/cloud/invoices.png
should also have a dark mode version 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this screenshot is not used in the Docs. The screenshots for the settings' invoice page are:
settings_invoices.png
settings_invoices_DARK.png
On this topic, would it be possible to remove the outdated screenshots that are no longer in use? It would make it easier to keep track of the ones that need maintenance. Some examples:
account-billing.png
account-deletion.png
advanced.png
plan-selection.png
Let me know if there's a reason for keeping them though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, so maybe invoices
was added to this PR by error? 😅
I'd say that we keep older screenshots because it's (kind of) a burden to take them (until we find a way to automate them, maybe one day 🤞), so we prefer to keep an archive—if anything breaks we can still quickly revert to an old one. That's why you'll also see some of them with _2
or _3
in their name.
I understand this might be confusing while maintaining them. I'd recommend looking at the Markdown files and the image files they reference, instead of treating the assets folder out of context, would that help for further maintenance tasks? 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think I got confused because of what I said above about old screenshots.
Yes sure! If not deleting them, we could maybe have an archive folder. But the way you said it works too, I'll just be extra careful next time.
Co-authored-by: mariekirsch <[email protected]>
What does it do?
Updates all the screenshots in the Cloud Settings documentation section
(excl. Environments & Backups screenshots which are updated in #2582)
Why is it needed?
To reflect changes made to the UI over the past 6 months