Skip to content

Add param isconstant to stimp #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 12, 2023

Conversation

NimaSarajpoor
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (dfa6d77) 99.13% compared to head (b24046c) 99.13%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #878   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          83       83           
  Lines       14083    14142   +59     
=======================================
+ Hits        13961    14020   +59     
  Misses        122      122           
Impacted Files Coverage Δ
stumpy/stimp.py 100.00% <100.00%> (ø)
tests/test_stimp.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seanlaw
Copy link
Contributor

seanlaw commented Jul 11, 2023

Looks good so far!

@NimaSarajpoor
Copy link
Collaborator Author

NimaSarajpoor commented Jul 12, 2023

@seanlaw
The tests are passing now. We may investigate the error in the previous run of GitHub actions in a separate PR. I can open an issue for it so that we do not forget. What do you think?

Also:
Is there anything else that needs to be done for this PR?

@seanlaw
Copy link
Contributor

seanlaw commented Jul 12, 2023

The tests are passing now. We may investigate the error in the previous run of GitHub actions in a separate PR. I can open an issue for it so that we do not forget. What do you think?

Yes, please do.

Also:
Is there anything else that needs to be done for this PR?

Thanks again for completing this PR, @NimaSarajpoor !

@seanlaw seanlaw merged commit 60f77db into stumpy-dev:main Jul 12, 2023
@seanlaw seanlaw mentioned this pull request Jul 12, 2023
@NimaSarajpoor NimaSarajpoor deleted the add_isconstant_stimp branch September 4, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants