-
-
Notifications
You must be signed in to change notification settings - Fork 82
feat: improved named prepared statements support #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It's suboptimal to send a lot of small packets, instead we should try to chunk when possible to ensure better network utilization
Used a hardcoded constant of 200
We may receive a Parse -> Sync sequence
@@ -256,7 +270,10 @@ | |||
def handle_event(:info, {proto, _, bin}, _, %{replica_type: :read} = data) | |||
when proto in @proto do | |||
Logger.debug("DbHandler: Got read replica message #{inspect(bin)}") | |||
pkts = Server.decode(bin) | |||
|
|||
# TODO: use streaming for read replica too |
Check warning
Code scanning / Credo
Found a TODO tag in a comment: # TODO: use streaming for read replica too Warning
7f45f6e
to
4cd2835
Compare
fix dialyzer, remove bad docs wip
4cd2835
to
2badfa1
Compare
1e704e9
to
e5d13c0
Compare
30ffe54
to
50d4042
Compare
Pushed some architecture changes. Instead of using Also did some refactoring for better splitting of responsibilities, and a feature flag for prepared statements. |
Adds support for Prepared Statements through the Extended Query Protocol.
Concept
This PR implements the following architecture:
bind
packet to the DbHandler, it should also send the respectiveparse
(which it has stored)Parsing/decoding
Limits
Potential next steps
Additional features