Skip to content

feat: typed params prop for page/layout components #13999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Conversation

Rich-Harris
Copy link
Member

Closes #13904, though it looks like we need a corresponding update in language-tools @dummdidumm — if only params is used, it's typed as any...

image

...whereas if data is also used then we get a squiggly:

image

We can of course use the type explicitly:

image

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jul 15, 2025

🦋 Changeset detected

Latest commit: 5740c51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

language tools will be handled by sveltejs/language-tools#2795

@Rich-Harris
Copy link
Member Author

neat! I guess we should merge that first

@Rich-Harris Rich-Harris merged commit 309ae8d into main Jul 15, 2025
21 checks passed
@Rich-Harris Rich-Harris deleted the gh-13904 branch July 15, 2025 14:04
@github-actions github-actions bot mentioned this pull request Jul 15, 2025
alexanderkiel added a commit to samply/blaze that referenced this pull request Aug 11, 2025
alexanderkiel added a commit to samply/blaze that referenced this pull request Aug 11, 2025
github-merge-queue bot pushed a commit to samply/blaze that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass params to +layout.svelte and +page.svelte components
2 participants