Consumer: assign / subscribe on run()
#133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We should start assignments / subscriptions when `KafkaConsumer.run()` is invoked and not on initialization. Modifications: * `KafkaConsumer`: move `assign` / `subscribe` from `init` to `func run()`
FranzBusch
reviewed
Sep 20, 2023
Comment on lines
+327
to
+332
| switch self.configuration.consumptionStrategy._internal { | ||
| case .partition(topic: let topic, partition: let partition, offset: let offset): | ||
| try self.assign(topic: topic, partition: partition, offset: offset) | ||
| case .group(groupID: _, topics: let topics): | ||
| try self.subscribe(topics: topics) | ||
| } |
There was a problem hiding this comment.
We should probably go through the state machine here
There was a problem hiding this comment.
func assign() and func subscribe() already go through the state machine by invoking stateMachine.setupConnection
I could however hoist the state check to func run() (so state check -> check consumption strategy -> assign / subscribe instead of check consumption strategy -> state check -> assign / subscribe)
There was a problem hiding this comment.
Ah got you. Just to double check if somebody called run twice we wouldn't subscribe twice right?
There was a problem hiding this comment.
Yes, it only works when in state .initializing 👍
FranzBusch
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We should start assignments / subscriptions when
KafkaConsumer.run()is invoked and not on initialization.
Modifications:
KafkaConsumer: moveassign/subscribefrominittofunc run()