[BoundsSafety] Don't bind lvalues with temporary locations #10989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix a miscompilation bug found during adoption. When a base is lvalue and is wrapped in OVE, the compiler incorrectly creates a temporary and maps its address to the lvalue instead of the actual address of the lvalue. The solution is to emit lvalue directly instead of creating extra temporary. rdar://146329029 (cherry picked from commit 8dd1309)
…ing in order to avoid non-determinism The execution order of arguments is unspecified in C++. Directly passing calls that emit code as arguments caused non-deterministic order in the generated instructions and test failures in different platforms. (cherry picked from commit 0a18d9a)
(cherry picked from commit 45afadf)
rapidsna
added
the
clang:bounds-safety
|
@swift-ci test llvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a miscompilation bug found during adoption.
When a base is lvalue and is wrapped in OVE, the compiler
incorrectly creates a temporary and maps its address to the lvalue
instead of the actual address of the lvalue.
The solution is to emit lvalue directly instead of creating
extra temporary.
rdar://146329029