[BoundsSafety] make alloc_size imply __sized_by_or_null return type #10991
+1,288
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnrklssn
requested review from
delcypher,
rapidsna,
patrykstefanski and
apple-fcloutier
When -fbounds-safety is enabled, the semantics of the return value of functions is that of __sized_by_or_null. Unlike return types annotated with __sized_by_or_null, it is never included in the type system. Instead every relevant analysis and transformation has to specifically check for the alloc_size attribute. This patch infers a __sized_by_or_null return type for functions annotated with alloc_size. This enables us to remove those special cases and reduce complexity. rdar://118338657 rdar://91017404 rdar://11833865
hnrklssn
force-pushed
the
alloc-size-sized-by-or-null
branch
from
7b8d848 to
f98c1fa
Compare
|
@swift-ci please test llvm |
1 similar comment
|
@swift-ci please test llvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When -fbounds-safety is enabled, the semantics of the return value of
functions is that of __sized_by_or_null. Unlike return types annotated
with __sized_by_or_null, it is never included in the type system.
Instead every relevant analysis and transformation has to specifically
check for the alloc_size attribute.
This patch infers a __sized_by_or_null return type for functions
annotated with alloc_size. This enables us to remove those special
cases and reduce complexity.
rdar://118338657
rdar://91017404
rdar://11833865