[6.2][CAS] Delay CAS initialization on server side after daemon starts #11001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachemeifyoucan
commented
Jul 14, 2025
cachemeifyoucan
commented
- Explanation: Delay CAS initialization in cc1depscan until after daemon is established so daemon can scan the CAS and recovery from any error if possible.
- Scope: Avoid a dead-lock caused timeout when CAS is corrupted when building using a daemon based caching build.
- Issues: rdar://155342429
- Original PRs: [CAS] Delay CAS initialization on server side after daemon starts #10978
- Risk: Low. This handles a corner cases when CAS is corrupted.
- Testing: Unit test.
- Reviewers: @benlangmuir
For auto CAS validation and recovery, it is important that server does not open the CAS until daemon replies so daemon has the chance to validate and recovery from broken CAS if needed. Otherwise, this is going to be a dead lock on daemon waiting for server to close the CAS before deletion. rdar://155342429 (cherry picked from commit 4095d2d)
|
@swift-ci please test |
akyrtzi
approved these changes
Jul 14, 2025
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.