Remove unreachable 'declarations' grammar production #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These grammar productions were commented out in 2014 by commit 0f8a59f, as part of revising the grammar for enumeration declarations.
This production was formerly used by the old, commented-out approach to enum declaration grammar that the previous commit deleted. Co-authored-by: Sarah Canto <[email protected]>
bjlanier
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This production used to be part of the old approach to enum grammar — see commit 0f8a59f. Brian, can you think of any reasons we might want to keep the old approach around? (You committed it, but most likely you and I wrote it together.)
Fixes: #187