Skip to content

Fix the first letter of a referencing function name in Macros. #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

es-kumagai
Copy link

@es-kumagai es-kumagai commented Oct 3, 2023

In Macro section, a function is referenced as FourCharacterCode, but its actual definition is fourCharacterCode.
Correcting the reference.

@es-kumagai es-kumagai changed the title Fix the first letter of a referencing function name. Fix the first letter of a referencing function name in Macros. Oct 3, 2023
@amartini51 amartini51 self-requested a review October 3, 2023 17:45
@es-kumagai
Copy link
Author

Sorry, 4ea9215 has a wrong commit message.

Copy link
Member

@amartini51 amartini51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this is a typo. The function is defined on line 541.

@es-kumagai
Copy link
Author

es-kumagai commented Oct 3, 2023

I'd like to fix the commit message,
from: In Macro section, a function is referenced as , but its actual definition is .
to: In Macro section, a function is referenced as 'FourCharacterCode', but its actual definition is 'fourCharacterCode'.

I will try it now.

@amartini51
Copy link
Member

@es-kumagai Do you want to force push your fix to the commit? Or is it ok if I edit the commit message and force push to your branch?

I think that commit is also ok if you just write "Fix typo in function name". Because anybody who reads the commit will see in the diff what the typo was.

Thanks for the three fixes today. If you find more minor errors in the future, you can make one PR with multiple corrections.

@es-kumagai
Copy link
Author

Thank you for your reply.
That commit message spans multiple lines.
I'd like to fix and force push, I will try it now.

@es-kumagai es-kumagai force-pushed the macro-fix-function-name branch from 4ea9215 to cd43aab Compare October 3, 2023 17:56
@es-kumagai
Copy link
Author

es-kumagai commented Oct 3, 2023

I've completed the fix.

@amartini51
Copy link
Member

Thanks, I see your change, but now the commit message has very long lines. This makes the commit hard to read, because many Git tools expect lines <80 characters. This is a minor issue, but I'll correct it for you.

@amartini51 amartini51 force-pushed the macro-fix-function-name branch from cd43aab to 1580297 Compare October 3, 2023 18:02
@amartini51 amartini51 merged commit 0a29526 into swiftlang:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants