[Tests] Do not share underlying Oracle for caching tests #1954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
artemcm
approved these changes
Jul 7, 2025
After rewriting the scanning service, oracle can get a race condition when CAS configuration is changed in between builds. It causes clang dependency scanning using a wrong CAS when scanning after some other thread updated the CAS location. Fix the occasional race condition by not sharing the orcale between all the tests sicne this is not a valid real world configuration. In the future, we should teach clang scanner not to hold a global CAS instance so service can be shared when switching CAS locations in a racy way. rdar://154592458
cachemeifyoucan
force-pushed
the
eng/PR-154592458
branch
from
de2446c to
fa7ff7f
Compare
|
@swift-ci please test |
|
@swift-ci please test windows platform |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After rewriting the scanning service, oracle can get a race condition when CAS configuration is changed in between builds. It causes clang dependency scanning using a wrong CAS when scanning after some other thread updated the CAS location.
Fix the occasional race condition by not sharing the orcale between all the tests sicne this is not a valid real world configuration. In the future, we should teach clang scanner not to hold a global CAS instance so service can be shared when switching CAS locations in a racy way.
rdar://154592458