Update sdk-amd64.wxs #170
Merged
Update sdk-amd64.wxs #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update installer manifest for new introduced dispatch header.
swiftlang/swift-corelibs-libdispatch#771 introduced a new header and broke the Windows toolchain due to the missing header. Update the SDK manifest accordingly which is required to get SPM to work again.
|
CC: @MaxDesiatov |
compnerd
added a commit
to compnerd/apple-swift
that referenced
this pull request
Jan 25, 2023
|
Unfortunately, only @shahmishal can approve on this repo and that is required - please make sure that we get this in ASAP (assuming that swiftlang/swift#63216 is good). We should also retrigger a nightly snapshot build after this is merged - the Windows builds haven't been updated in a while. |
MarSe32m
reviewed
Jan 25, 2023
shahmishal
approved these changes
Jan 25, 2023
|
This will need to be squashed before merging. |
MaxDesiatov
reviewed
Jan 25, 2023
MaxDesiatov
reviewed
Jan 25, 2023
MaxDesiatov
reviewed
Jan 25, 2023
|
The testing PR on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update installer manifest for new introduced dispatch header.