refactor authorization provider setup #4074
Conversation
|
@swift-ci please smoke test |
| if let userHomeProvider = loadNetrcNoThrows(at: userHomePath) { | ||
| providers.append(userHomeProvider) | ||
| } | ||
| let rootPath = try options.multirootPackageDataFile ?? self.getPackageRoot() |
There was a problem hiding this comment.
I know this is just moving the code, but I am not sure if it this is actually correct for multi root. This will be a file path, not a directory, so essentially never work.
There was a problem hiding this comment.
interesting, the entire code in SwiftTool treats multirootPackageDataFile as the root directory, sounds like that's not working (and that we are missing some tests?)
There was a problem hiding this comment.
Oh, I see how it works, options.multirootPackageDataFile is actually pointing to a .xcworkspace which is a directory. I think we should change this to use xcshareddata because this is a configuration file.
There was a problem hiding this comment.
To be clear, what I mean is use multiRootPackageDataFile.appending(components: "xcshareddata") as the root path here.
There was a problem hiding this comment.
sounds like good material for follow on PR? it is used in various spots
tomerd
force-pushed
the
refactor/authorization-provider
branch
from
36f72ef to
9307725
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
tomerd
added
the
ready
tomerd
force-pushed
the
refactor/authorization-provider
branch
from
d7aa798 to
074eff2
Compare
|
@swift-ci please smoke test |
|
lets get #4079 in first, then we can rebase this one on top |
tomerd
force-pushed
the
refactor/authorization-provider
branch
from
7e50f47 to
8a7d883
Compare
|
@swift-ci please smoke test |
tomerd
force-pushed
the
refactor/authorization-provider
branch
2 times, most recently
from
04ca6df to
b454f30
Compare
motivation: more easily share authorization provider setup with libSwiftPM users changes: * move authorization providers setup from SwiftTool to a Worksapce configuraiton utility * adjust call sites and tests
tomerd
force-pushed
the
refactor/authorization-provider
branch
from
b454f30 to
a0011b2
Compare
|
@swift-ci please smoke test |
|
source compat looks good: swiftlang/swift#41142 i think this is good to go. @yim-lee want to take one last look? |
|
LGTM 👍 |
|
@neonichu this is now merged so can be used downstream |
motivation: more easily share authorization provider setup with libSwiftPM users
changes: