[5.9] Backport macOS CI related changes #6539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Re-enable disabled tests This re-enables a bunch of disabled tests, the hope is that they should now work that we have a newer superior Xcode installed on CI. If that happens to not be the case, we have `SWIFTCI_DISABLE_SDK_DEPENDENT_TESTS` to disable these tests specifically for the macOS CI if needed. This change introduces the variable where expected to be needed, but doesn't set it. * Removed back deployment rpaths * Removed more Darwin rpaths into the toolchain A macOS that contains the dyld issue worked around by swiftlang/swift#37978 has been deployed by Swift CI, so we can't do this anymore on Darwin. * Do not include Swift runtime libs in `DYLD_LIBRARY_PATH` on Darwin (cherry picked from commit 16fb1d2)
This is manifesting itself as `cannot find 'XCTAssertEqual' in scope` on Swift CI again, but instead of disabling these tests wholesale like we did before, we want to take a more targetted approach. (cherry picked from commit bc35b9c)
|
@swift-ci please smoke test |
|
|
Interesting that macOS self-hosted works... |
|
@swift-ci please smoke test linux |
|
Failure seems consistent. |
|
Seems like the test is passing in #6541, so there is an issue specific to this PR. |
|
Oh, I see, this is in |
|
@swift-ci please smoke test linux |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
Looks like these tests are suffering from some of the same problems as `FunctionalTests` which makes sense since they're conceptually very similar. (cherry picked from commit 2cb0f2f)
|
@swift-ci please smoke test |
|
@swift-ci please smoke test windows |
|
Hm, looks like triggering Windows doesn't work |
|
@swift-ci please smoke test windows |
tomerd
approved these changes
May 11, 2023
|
Linux failure is |
|
Windows failure is a crash |
|
@swift-ci please smoke test windows |
|
@swift-ci please smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports a couple of macOS CI related changes:
FunctionalTestswhich were previously generally disabledSWIFTCI_DISABLE_SDK_DEPENDENT_TESTSwhen running throughbootstrapon macOSFunctionalTestsandCommandsTestsbehind that environment variable