[6.1] Apply toolset's testRunner property in swift-test
#8258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Tests/CommandsTests/TestCommandTests.swift
MaxDesiatov
added
swift test
MaxDesiatov
changed the title
testToolsetRunner on macOStestRunner property in swift-test
Per [SE-0378 toolsets can specify an optional `testRunner` property](https://github.com/swiftlang/swift-evolution/blob/main/proposals/0387-cross-compilation-destinations.md#toolsetjson-files), which so far had no effect. We should respect this property in `swift test` invocations when any toolsets or Swift SDKs are selected. This allows testing cross-compiled products in an environment other than the host, e.g. a container runtime when cross-compiled to Linux, qemu or a firmware flasher and serial port setup script with Swift Embedded for microcontrollers, or in a Wasm runtime for a WASI binary. (cherry picked from commit 411cb43) # Conflicts: # Fixtures/Miscellaneous/EchoExecutable/toolset.json # Tests/CommandsTests/TestCommandTests.swift
(cherry picked from commit 1e980c3)
(cherry picked from commit da42e5a)
(cherry picked from commit 3ce1bbf) # Conflicts: # Fixtures/Miscellaneous/EchoExecutable/echo.sh # Tests/CommandsTests/RunCommandTests.swift # Tests/CommandsTests/TestCommandTests.swift
|
@swift-ci test |
MaxDesiatov
requested review from
bnbarham,
jakepetroules,
francescomikulis,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv and
bkhouri
as code owners
plemarquand
approved these changes
Jan 29, 2025
jakepetroules
approved these changes
Jan 29, 2025
bnbarham
approved these changes
Feb 3, 2025
|
@swift-ci test |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #8254 merged as b14e431.
Explanation: Per SE-0378 toolsets can specify an optional
testRunnerproperty, which so far had no effect. We should respect this property inswift testinvocations when any toolsets or Swift SDKs are selected.This allows testing cross-compiled products in an environment other than the host, e.g. a container runtime when cross-compiled to Linux, QEMU or a firmware flasher and serial port setup script with Swift Embedded for microcontrollers, or in a Wasm runtime for a Wasm binary.
Scope: Only impacts
swift-testwhen a toolset or a Swift SDK are selected.Risk: Low, due to limited scope and automated testing.
Testing: Added a new test cause to the existing XCTest suite.
Issue: rdar://143815066
Reviewer: @dschaefer2