Skip to content

Do not try to add rpath arguments on noneOS #8358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2025
Merged

Do not try to add rpath arguments on noneOS #8358

merged 2 commits into from
May 11, 2025

Conversation

rauhul
Copy link
Member

@rauhul rauhul commented Mar 11, 2025

Updates the ProductBuildDescription linkArgument's logic to avoid adding local rpaths for noneOS which does not support dynamically linked executables.

@rauhul
Copy link
Member Author

rauhul commented Mar 11, 2025

@swift-ci test

@rauhul rauhul added the embedded Support for Embedded Swift label Mar 11, 2025
@MaxDesiatov MaxDesiatov added the needs tests This change needs test coverage label Mar 11, 2025
MaxDesiatov
MaxDesiatov reviewed Mar 11, 2025
View reviewed changes
Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding tests to verify the behavior?

@rauhul
Do not try to add rpath arguments on noneOS
6b88cbb 
Updates the ProductBuildDescription linkArgument's logic to avoid adding
local rpaths for noneOS which does not support dynamically linked
executables.

Fixes: #8652
@rauhul rauhul force-pushed the rauhul/disable-rapths-on-os-none branch from 02577b4 to 6b88cbb Compare May 10, 2025 19:38
@rauhul rauhul linked an issue May 10, 2025 that may be closed by this pull request
rpaths shouldn't be used for noneOS #8652
Closed
1 task
@rauhul rauhul removed the needs tests This change needs test coverage label May 10, 2025
@rauhul
Copy link
Member Author

rauhul commented May 10, 2025

@swift-ci please test

@rauhul rauhul requested a review from MaxDesiatov May 10, 2025 23:37
@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@rauhul rauhul enabled auto-merge (squash) May 11, 2025 16:08
@rauhul rauhul merged commit 7a927cd into main May 11, 2025
6 checks passed
@rauhul rauhul deleted the rauhul/disable-rapths-on-os-none branch May 11, 2025 16:27
@rauhul rauhul mentioned this pull request May 12, 2025
Closed
3 tasks
@MaxDesiatov MaxDesiatov restored the rauhul/disable-rapths-on-os-none branch June 3, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDesiatov MaxDesiatov MaxDesiatov approved these changes

@jakepetroules jakepetroules jakepetroules approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham

@xedin xedin Awaiting requested review from xedin

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

@bkhouri bkhouri Awaiting requested review from bkhouri bkhouri is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

Assignees
No one assigned
Labels
embedded Support for Embedded Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rpaths shouldn't be used for noneOS
3 participants
@rauhul @MaxDesiatov @jakepetroules