Make supportedTriples optional in SDK metadata for universal SDKs
#91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For SDKs that can be universally used on any host platform, the `supportedTriples` field in the SDK metadata was previously required to fill all possible host triples. This change makes the `supportedTriples` field optional, allowing SDKs to be universally used without specifying any host triples, and Wasm SDK generator fills the field with null when `--host-swift-package-path` is not provided.
MaxDesiatov
reviewed
Mar 29, 2024
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SDKs that can be universally used on any host platform, the
supportedTriplesfield in the SDK metadata was previously required to fill all possible host triples.This change makes the
supportedTriplesfield optional, allowing SDKs to be universally used without specifying any host triples, and Wasm SDK generator fills the field with null when--host-swift-package-pathis not provided.We need SwiftPM side support as well. swiftlang/swift-package-manager#7432