Use uppercase CMAKE_BUILD_TYPE when asking for CMAKE_CXX_FLAGS, explicitly use -O0 for Debug builds #33896
Conversation
|
@swift-ci please test |
|
Build failed |
CMakeLists.txt
Outdated
| # CMake's default for CMAKE_CXX_FLAGS_DBEUG is "-g". Let's add "-O0", because we want to be able | ||
| # to append CMAKE_CXX_FLAGS_DEBUG to a list of compile flags that already contains a -O flag. | ||
| set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g") |
There was a problem hiding this comment.
should this preserve any provided value for CMAKE_CXX_FLAGS_DEBUG by appending -O0 instead of overwriting?
| @@ -630,6 +630,10 @@ if("${CMAKE_C_COMPILER_ID}" STREQUAL "MSVC" OR "${CMAKE_CXX_SIMULATE_ID}" STREQU | |||
| endif() | |||
|
|
|||
| if(NOT SWIFT_COMPILER_IS_MSVC_LIKE) | |||
| # CMake's default for CMAKE_CXX_FLAGS_DBEUG is "-g". Let's add "-O0", because we want to be able | |||
| # to append CMAKE_CXX_FLAGS_DEBUG to a list of compile flags that already contains a -O flag. | |||
There was a problem hiding this comment.
which list already has -O?
There was a problem hiding this comment.
@mikeash reported this when building a "release swift + debug stdlib" configuration. The stdlib in this case gets the "default compilation flags" and then we append the "debug stdlib" flags.
|
Build failed |
kubamracek
force-pushed
the
uppercase-o-zero
branch
from
c0445eb to
961d90a
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
kubamracek
force-pushed
the
uppercase-o-zero
branch
from
c4dcc36 to
63c9bd1
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
…citly use -O0 for Debug builds
kubamracek
force-pushed
the
uppercase-o-zero
branch
from
63c9bd1 to
3de1f75
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
No description provided.