[Distributed] correct take semantics for synthesized ID assignments #63779
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| // RUN: %empty-directory(%t) | ||
| // RUN: %target-swift-frontend-emit-module -emit-module-path %t/FakeDistributedActorSystems.swiftmodule -module-name FakeDistributedActorSystems -disable-availability-checking %S/../Inputs/FakeDistributedActorSystems.swift | ||
| // RUN: %target-swift-frontend -module-name default_deinit -primary-file %s -emit-sil -verify -disable-availability-checking -I %t | %FileCheck %s --enable-var-scope --dump-input=fail | ||
| // REQUIRES: concurrency | ||
| // REQUIRES: distributed | ||
|
|
||
| /// The convention in this test is that the Swift declaration comes before its FileCheck lines. | ||
|
|
||
| import Distributed | ||
| import FakeDistributedActorSystems | ||
|
|
||
| /// This actor system is a class, therefore SIL is slightly different | ||
| typealias DefaultDistributedActorSystem = FakeRoundtripActorSystem | ||
|
|
||
| // ==== ---------------------------------------------------------------------------------------------------------------- | ||
|
|
||
| class SomeClass {} | ||
|
|
||
| enum Err : Error { | ||
| case blah | ||
| } | ||
|
|
||
| func getSomeClass() throws -> SomeClass { throw Err.blah } | ||
| func getSystem() throws -> FakeRoundtripActorSystem { throw Err.blah } | ||
|
|
||
| distributed actor MyDistActor { | ||
| var someField: SomeClass | ||
|
|
||
| init() throws { | ||
| do { | ||
| actorSystem = try getSystem() | ||
| } catch { | ||
| actorSystem = FakeRoundtripActorSystem() | ||
| } | ||
| someField = try getSomeClass() | ||
| } | ||
|
|
||
|
There was a problem hiding this comment. This adds a test for a class based actor system which was a thing we didn't cover well, but in the real world most systems will be; This is the same as the other sil_n tests but for a class. |
||
| // CHECK: sil hidden @$s14default_deinit11MyDistActorCACyKcfc : $@convention(method) (@owned MyDistActor) -> (@owned MyDistActor, @error any Error) { | ||
| // CHECK: bb0([[SELF:%[0-9]+]] : $MyDistActor): | ||
| // CHECK: builtin "initializeDefaultActor"([[SELF]] : $MyDistActor) | ||
| // CHECK: try_apply {{%[0-9]+}}() : $@convention(thin) () -> (@owned FakeRoundtripActorSystem, @error any Error), normal [[SYSTEM_SUCCESS_BB:bb[0-9]+]], error [[SYSTEM_ERROR_BB:bb[0-9]+]] | ||
|
|
||
| // CHECK: [[SYSTEM_SUCCESS_BB]]([[SYSTEM_VAL:%[0-9]+]] : $FakeRoundtripActorSystem): | ||
| // *** save system *** | ||
| // CHECK: [[TP_FIELD1:%[0-9]+]] = ref_element_addr [[SELF]] : $MyDistActor, #MyDistActor.actorSystem | ||
| // CHECK: store [[SYSTEM_VAL]] to [[TP_FIELD1]] : $*FakeRoundtripActorSystem | ||
| // *** obtain an identity *** | ||
| // CHECK: [[TP_FIELD2:%[0-9]+]] = ref_element_addr [[SELF]] : $MyDistActor, #MyDistActor.actorSystem | ||
| // CHECK: [[RELOADED_SYS1:%[0-9]+]] = load [[TP_FIELD2]] : $*FakeRoundtripActorSystem | ||
| // CHECK: [[SELF_METATYPE:%[0-9]+]] = metatype $@thick MyDistActor.Type | ||
| // CHECK: strong_retain [[RELOADED_SYS1]] : $FakeRoundtripActorSystem | ||
| // CHECK: [[ASSIGN_ID_FN:%[0-9]+]] = function_ref @$s27FakeDistributedActorSystems0a9RoundtripC6SystemC8assignIDyAA0C7AddressVxm0B00bC0RzlF | ||
| // CHECK: [[ID:%[0-9]+]] = apply [[ASSIGN_ID_FN]]<MyDistActor>([[SELF_METATYPE]], [[RELOADED_SYS1]]) | ||
| // CHECK: strong_release [[RELOADED_SYS1]] : $FakeRoundtripActorSystem | ||
| // *** save identity *** | ||
| // CHECK: [[ID_FIELD:%[0-9]+]] = ref_element_addr [[SELF]] : $MyDistActor, #MyDistActor.id | ||
| // CHECK: store [[ID]] to [[ID_FIELD]] : $*ActorAddress | ||
| // CHECK-NOT: apply | ||
| // CHECK: br [[JOIN_PT:bb[0-9]+]] | ||
|
|
||
| // CHECK: [[JOIN_PT]]: | ||
| // CHECK: try_apply {{.*}}() : $@convention(thin) () -> (@owned SomeClass, @error any Error), normal [[CLASS_SUCCESS_BB:bb[0-9]+]], error [[CLASS_ERROR_BB:bb[0-9]+]] | ||
|
|
||
| // CHECK: [[CLASS_SUCCESS_BB]]{{.*}}: | ||
| // CHECK: store {{.*}} to {{.*}} : $*SomeClass | ||
| // *** invoke actorReady *** | ||
| // CHECK: [[TP_FIELD3:%[0-9]+]] = ref_element_addr [[SELF]] : $MyDistActor, #MyDistActor.actorSystem | ||
| // CHECK: [[RELOADED_SYS2:%[0-9]+]] = load [[TP_FIELD3]] : $*FakeRoundtripActorSystem | ||
| // CHECK: [[READY_FN:%[0-9]+]] = function_ref @$s27FakeDistributedActorSystems0a9RoundtripC6SystemC10actorReadyyyx0B00bC0RzAA0C7AddressV2IDRtzlF | ||
| // CHECK: = apply [[READY_FN]]<MyDistActor>([[SELF]], [[RELOADED_SYS2]]) | ||
| // CHECK: return [[SELF]] : $MyDistActor | ||
|
|
||
| // CHECK: [[SYSTEM_ERROR_BB]]([[ERROR_ARG:%[0-9]+]] : $any Error): | ||
| // CHECK: strong_retain [[ERROR_ARG]] : $any Error | ||
| // CHECK: function_ref @$s27FakeDistributedActorSystems0a9RoundtripC6SystemCACycfC | ||
| // CHECK: store {{.*}} to {{.*}} : $*FakeRoundtripActorSystem | ||
| // CHECK: store {{.*}} to {{.*}} : $*ActorAddress | ||
| // CHECK: br [[JOIN_PT]] | ||
|
|
||
| // CHECK: [[CLASS_ERROR_BB]]{{.*}}: | ||
| // ** deinit the id ** | ||
| // CHECK: [[REF_ID_D:%[0-9]+]] = ref_element_addr [[SELF]] : $MyDistActor, #MyDistActor.id | ||
| // CHECK: [[ID_D:%[0-9]+]] = begin_access [deinit] [static] [[REF_ID_D]] : $*ActorAddress | ||
| // CHECK: [[REF_SYS_D:%[0-9]+]] = ref_element_addr [[SELF]] : $MyDistActor, #MyDistActor.actorSystem | ||
| // CHECK: [[ID:%[0-9]+]] = load [[ID_D]] : $*ActorAddress | ||
| // CHECK: [[SYS:%[0-9]+]] = load [[REF_SYS_D]] : $*FakeRoundtripActorSystem | ||
| // CHECK: [[RESIGN_FN:%[0-9]+]] = function_ref @$s27FakeDistributedActorSystems0a9RoundtripC6SystemC8resignIDyyAA0C7AddressVF | ||
| // CHECK: = apply [[RESIGN_FN]]([[ID]], [[SYS]]) : $@convention(method) (@guaranteed ActorAddress, @guaranteed FakeRoundtripActorSystem) -> () | ||
| // CHECK: destroy_addr [[ID_D]] : $*ActorAddress | ||
| // CHECK: end_access [[ID_D]] : $*ActorAddress | ||
| // ** deinit the system ** | ||
| // CHECK: [[REF_SYS_D2:%[0-9]+]] = ref_element_addr [[SELF]] : $MyDistActor, #MyDistActor.actorSystem | ||
| // CHECK: [[SYSTEM_ACC:%[0-9]+]] = begin_access [deinit] [static] [[REF_SYS_D2]] : $*FakeRoundtripActorSystem | ||
| // CHECK: destroy_addr [[SYSTEM_ACC]] : $*FakeRoundtripActorSystem | ||
| // CHECK: end_access [[SYSTEM_ACC]] : $*FakeRoundtripActorSystem | ||
| // CHECK: builtin "destroyDefaultActor"([[SELF]] : $MyDistActor) : $() | ||
| // CHECK: dealloc_partial_ref [[SELF]] | ||
| // CHECK: throw | ||
|
|
||
|
|
||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| // RUN: %empty-directory(%t) | ||
| // RUN: %target-swift-frontend-emit-module -emit-module-path %t/FakeDistributedActorSystems.swiftmodule -module-name FakeDistributedActorSystems -disable-availability-checking %S/../Inputs/FakeDistributedActorSystems.swift | ||
| // RUN: %target-swift-frontend -module-name default_deinit -primary-file %s -emit-sil -verify -disable-availability-checking -I %t | %FileCheck %s --enable-var-scope --dump-input=fail | ||
| // REQUIRES: concurrency | ||
| // REQUIRES: distributed | ||
|
|
||
| /// The convention in this test is that the Swift declaration comes before its FileCheck lines. | ||
|
|
||
| import Distributed | ||
| import FakeDistributedActorSystems | ||
|
|
||
| typealias DefaultDistributedActorSystem = FakeRoundtripActorSystem | ||
|
|
||
| // ==== ---------------------------------------------------------------------------------------------------------------- | ||
|
|
||
| distributed actor MyDistActor { | ||
|
|
||
| // protocol witness for DistributedActorSystem.resolve<A>(id:as:) in conformance FakeRoundtripActorSystem | ||
| // CHECK: sil hidden @$s14default_deinit11MyDistActorC7resolve2id5usingAC015FakeDistributedE7Systems0E7AddressV_AG0i9RoundtripE6SystemCtKFZ | ||
| // CHECK: bb0([[ACTOR_ID_ARG:%[0-9]+]] : $ActorAddress, [[SYSTEM_ARG:%[0-9]+]] : $FakeRoundtripActorSystem, [[TYPE_ARG:%[0-9]+]] : $@thick MyDistActor.Type): | ||
| // CHECK: [[SYS_RESOLVE_RESULT:%[0-9]+]] = function_ref @$s27FakeDistributedActorSystems0a9RoundtripC6SystemC7resolve2id2asxSgAA0C7AddressV_xmtK0B00bC0RzlF | ||
|
|
||
| // CHECK: // makeProxyBB | ||
| // CHECK: [[ACTOR_INSTANCE:%[0-9]+]] = builtin "initializeDistributedRemoteActor"(%7 : $@thick MyDistActor.Type) : $MyDistActor | ||
| // CHECK: [[ID_PROPERTY:%[0-9]+]] = ref_element_addr [[ACTOR_INSTANCE]] : $MyDistActor, #MyDistActor.id | ||
| // CHECK: retain_value [[ACTOR_ID_ARG]] : $ActorAddress | ||
| // CHECK: store [[ACTOR_ID_ARG]] to [[ID_PROPERTY]] : $*ActorAddress | ||
| // CHECK: [[SYSTEM_PROPERTY:%[0-9]+]] = ref_element_addr [[ACTOR_INSTANCE]] : $MyDistActor, #MyDistActor.actorSystem | ||
| // CHECK: strong_retain [[SYSTEM_ARG]] : $FakeRoundtripActorSystem | ||
| // CHECK: store [[SYSTEM_ARG]] to [[SYSTEM_PROPERTY]] : $*FakeRoundtripActorSystem | ||
| // CHECK: br bb5([[ACTOR_INSTANCE]] : $MyDistActor) | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // RUN: %empty-directory(%t) | ||
| // RUN: %target-swift-frontend-emit-module -emit-module-path %t/FakeDistributedActorSystems.swiftmodule -module-name FakeDistributedActorSystems -disable-availability-checking %S/../Inputs/FakeDistributedActorSystems.swift | ||
| // RUN: %target-swift-frontend -verify -emit-sil -module-name main -disable-availability-checking -parse-as-library -I %t %s %S/../Inputs/FakeDistributedActorSystems.swift | %FileCheck %s | ||
|
|
||
| // REQUIRES: concurrency | ||
| // REQUIRES: distributed | ||
|
|
||
| // rdar://76038845 | ||
| // UNSUPPORTED: use_os_stdlib | ||
| // UNSUPPORTED: back_deployment_runtime | ||
|
|
||
| // FIXME(distributed): Distributed actors currently have some issues on windows, isRemote always returns false. rdar://82593574 | ||
| // UNSUPPORTED: OS=windows-msvc | ||
|
|
||
| import Distributed | ||
| import FakeDistributedActorSystems | ||
|
|
||
| /// This type uses a non loadable (size not known at compile time) ID which forces the actor's init SILGen | ||
| /// to make use of the isAddressOnly handling of the ID assignments. | ||
| /// | ||
| /// This test covers rdar://104583893 / https://github.com/apple/swift/issues/62898 | ||
| /// And used to fail with: | ||
| /// SIL memory lifetime failure in @$s18DistributedCluster0B16EventStreamActorC11actorSystemAcA0bG0C_tcfc: memory is initialized, but shouldn't be | ||
| typealias DefaultDistributedActorSystem = FakeNotLoadableAddressActorSystem | ||
|
|
||
| distributed actor Greeter { | ||
|
|
||
| init(actorSystem: ActorSystem) { | ||
| self.actorSystem = actorSystem | ||
| } | ||
|
|
||
| distributed func echo(name: String) -> String { | ||
| return "Echo: \(name)" | ||
| } | ||
| } | ||
|
|
||
| // CHECK: sil hidden @$s4main7GreeterC7resolve2id5usingAcA23NotLoadableActorAddressV_AA04FakefgiH6SystemVtKFZ : $@convention(method) (@in_guaranteed NotLoadableActorAddress, @guaranteed FakeNotLoadableAddressActorSystem, @thick Greeter.Type) -> (@owned Greeter, @error any Error) { | ||
| // CHECK: bb0([[ADDRESS_ARG:%[0-9]+]] : $*NotLoadableActorAddress, [[SYSTEM_ARG:%[0-9]+]] : $FakeNotLoadableAddressActorSystem, [[TYPE_ARG:%[0-9]+]] : $@thick Greeter.Type): | ||
| // CHECK: [[TYPE:%[0-9]+]] = metatype $@thick Greeter.Type | ||
|
|
||
| // CHECK: // makeProxyBB | ||
| // CHECK: [[INSTANCE:%[0-9]+]] = builtin "initializeDistributedRemoteActor"([[TYPE]] : $@thick Greeter.Type) : $Greeter | ||
| // CHECK: [[ID_PROPERTY:%[0-9]+]] = ref_element_addr [[INSTANCE]] : $Greeter, #Greeter.id | ||
| // Note specifically that we don't [take] in the below copy_addr: | ||
| // CHECK: copy_addr [[ADDRESS_ARG]] to [init] [[ID_PROPERTY]] : $*NotLoadableActorAddress | ||
|
|
||
| func test() async throws { | ||
| let system = DefaultDistributedActorSystem() | ||
|
|
||
| let local = Greeter(actorSystem: system) | ||
| _ = try await local.echo(name: "Caplin") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue was here, so changing to take here is correct, but the other sites want to remain not-take.
Thanks @eeckstein and @drexin for the pointers !