Skip to content

Do Not Merge: generate toolchain with NoncopyableGenerics #71397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Do Not Merge: generate toolchain with NoncopyableGenerics #71397

wants to merge 2 commits into from

Conversation

kavon
Copy link
Member

@kavon kavon commented Feb 5, 2024

No description provided.

@kavon
Copy link
Member Author

kavon commented Feb 5, 2024

@swift-ci Please Build Toolchain macOS Platform

1 similar comment
@kavon
Copy link
Member Author

kavon commented Feb 8, 2024

@swift-ci Please Build Toolchain macOS Platform

@kavon kavon force-pushed the ncgenerics-toolchain-preset branch 2 times, most recently from 346fb67 to a1f20e0 Compare February 8, 2024 22:51
@kavon
Copy link
Member Author

kavon commented Feb 8, 2024

@swift-ci Please Build Toolchain macOS Platform

1 similar comment
@kavon
Copy link
Member Author

kavon commented Feb 9, 2024

@swift-ci Please Build Toolchain macOS Platform

@kavon
Copy link
Member Author

kavon commented Feb 9, 2024 

[8/18] Compiling MacroExamplesImplementation DictionaryIndirectionMacro.swift
/Users/ec2-user/jenkins/workspace/swift-PR-toolchain-macos/branch-main/swift-syntax/Examples/Sources/MacroExamples/Implementation/ComplexMacros/OptionSetMacro.swift:182:56: warning: 'flatMap' is deprecated: Please use compactMap(_:) for the case where closure returns an optional value
    let caseElements = optionsEnum.memberBlock.members.flatMap { member in
                                                       ^
/Users/ec2-user/jenkins/workspace/swift-PR-toolchain-macos/branch-main/swift-syntax/Examples/Sources/MacroExamples/Implementation/ComplexMacros/OptionSetMacro.swift:182:56: note: use 'compactMap(_:)' instead
    let caseElements = optionsEnum.memberBlock.members.flatMap { member in
                                                       ^~~~~~~
                                                       compactMap
/Users/ec2-user/jenkins/workspace/swift-PR-toolchain-macos/branch-main/swift-syntax/Examples/Sources/MacroExamples/Implementation/ComplexMacros/OptionSetMacro.swift:195:38: error: value of type '[EnumCaseElementSyntax]' has no member 'name'
      \(access) static let \(element.name): Self =
                             ~~~~~~~ ^~~~
Error: Command failed with non-zero exit code 1:

@kavon
Copy link
Member Author

kavon commented Feb 10, 2024

swiftlang/swift-syntax#2490
@swift-ci Please Build Toolchain macOS Platform

@kavon
Copy link
Member Author

kavon commented Feb 12, 2024

@swift-ci Please Build Toolchain macOS Platform

@kavon kavon force-pushed the ncgenerics-toolchain-preset branch from 08d3ec6 to 64face5 Compare February 12, 2024 00:45
@kavon
Copy link
Member Author

kavon commented Feb 12, 2024

@swift-ci Please Build Toolchain macOS Platform

@kavon
Copy link
Member Author

kavon commented Feb 12, 2024

Also an issue building swift-markdown:

/Users/ec2-user/jenkins/workspace/swift-PR-toolchain-macos/branch-main/swift-markdown/Sources/Markdown/Base/RawMarkup.swift:95:24: error: type 'RawMarkup' does not conform to protocol 'Copyable'
final class RawMarkup: ManagedBuffer<RawMarkupHeader, RawMarkup> {
                       ^

@kavon
Copy link
Member Author

kavon commented Feb 12, 2024

@swift-ci Please Build Toolchain macOS Platform

@kavon kavon force-pushed the ncgenerics-toolchain-preset branch from 884ccdf to ef3888f Compare February 13, 2024 17:43
@kavon
Copy link
Member Author

kavon commented Feb 13, 2024

@swift-ci Please Build Toolchain macOS Platform

@kavon kavon force-pushed the ncgenerics-toolchain-preset branch from ef3888f to 2bc1fab Compare February 14, 2024 00:44
@kavon
Copy link
Member Author

kavon commented Feb 14, 2024

@swift-ci Please Build Toolchain macOS Platform

@glessard
Copy link
Contributor

https://ci.swift.org/job/swift-PR-toolchain-macos/1090/artifact/branch-main/swift-PR-71397-1090-osx.tar.gz

@kavon kavon closed this Mar 6, 2024
tbkka
tbkka reviewed Mar 7, 2024
View reviewed changes
stdlib/cmake/modules/SwiftSource.cmake
@@ -610,6 +610,7 @@ function(_compile_swift_files
if(SWIFT_ENABLE_EXPERIMENTAL_NONCOPYABLE_GENERICS)
list(APPEND swift_flags "-enable-experimental-feature" "NoncopyableGenerics")
list(APPEND swift_flags "-Xfrontend" "-enable-experimental-associated-type-inference")
list(APPEND swift_flags "-Xfrontend" "-disable-round-trip-debug-types") # NOTE: temporary until we fix mangling!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be able to remove this from this PR now?

tbkka
tbkka reviewed Mar 7, 2024
View reviewed changes
utils/build-presets.ini
@@ -1383,7 +1386,6 @@ darwin-toolchain-require-use-os-runtime=1
[preset: buildbot_osx_package]
mixin-preset=
mixin_osx_package_base
mixin_osx_package_test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How close are we to being able to remove this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkka tbkka tbkka left review comments

@artemcm artemcm Awaiting requested review from artemcm artemcm will be requested when the pull request is marked ready for review artemcm is a code owner

@tshortli tshortli Awaiting requested review from tshortli tshortli will be requested when the pull request is marked ready for review tshortli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kavon @glessard @tbkka