Skip to content

Unversioned clang resource OS name #82504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

etcwilde
Copy link
Member

The clang resource directory generally does not use a versioned form of the platform name. This aligns the old driver behavior with the new driver for FreeBSD support.

https://github.com/swiftlang/swift-driver/blob/a7f32bd005de1b998495ddc052bf78fc3cebdaa5/Sources/SwiftDriver/Jobs/GenericUnixToolchain%2BLinkerSupport.swift#L309

@etcwilde etcwilde requested a review from artemcm as a code owner June 25, 2025 21:24
@etcwilde
Copy link
Member Author

@swift-ci please test

@etcwilde etcwilde moved this to In Progress in Swift on FreeBSD Jun 25, 2025
@etcwilde etcwilde self-assigned this Jun 25, 2025
The clang resource directory generally does not use a versioned form of
the platform name. This aligns the old driver behavior with the new
driver for FreeBSD support.

https://github.com/swiftlang/swift-driver/blob/a7f32bd005de1b998495ddc052bf78fc3cebdaa5/Sources/SwiftDriver/Jobs/GenericUnixToolchain%2BLinkerSupport.swift#L309
@etcwilde etcwilde force-pushed the ewilde/unversioned-clang-resource-dirs branch from 3288398 to dbe7c13 Compare June 25, 2025 21:26
@etcwilde
Copy link
Member Author

@swift-ci please test

1 similar comment
@etcwilde
Copy link
Member Author

@swift-ci please test

@etcwilde
Copy link
Member Author

@swift-ci please test Windows

1 similar comment
@etcwilde
Copy link
Member Author

etcwilde commented Jul 1, 2025

@swift-ci please test Windows

@etcwilde etcwilde merged commit 6e9c010 into swiftlang:main Jul 2, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Swift on FreeBSD Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants