[NFC][RemoteInspection] Add an opaque AddressSpace field to RemoteAddress #82638
+979
−718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusto2112
force-pushed
the
change-remote-addr
branch
from
2133870 to
b031186
Compare
augusto2112
requested review from
slavapestov,
a team and
DougGregor
as code owners
augusto2112
force-pushed
the
change-remote-addr
branch
from
b031186 to
c8906b3
Compare
augusto2112
changed the title
augusto2112
force-pushed
the
change-remote-addr
branch
from
c8906b3 to
434fe88
Compare
mikeash
approved these changes
Jul 7, 2025
augusto2112
force-pushed
the
change-remote-addr
branch
from
434fe88 to
0368168
Compare
mikeash
reviewed
Jul 7, 2025
augusto2112
force-pushed
the
change-remote-addr
branch
from
0368168 to
faa6b7d
Compare
augusto2112
force-pushed
the
change-remote-addr
branch
from
faa6b7d to
83096c8
Compare
augusto2112
force-pushed
the
change-remote-addr
branch
from
83096c8 to
f402316
Compare
augusto2112
force-pushed
the
change-remote-addr
branch
from
f402316 to
e6d807a
Compare
…ress Add an extra opaque field to AddressSpace, which can be used by clients of RemoteInspection to distinguish between different address spaces. LLDB employs an optimization where it reads memory from files instead of the running process whenever it can to speed up memory reads (these can be slow when debugging something over a network). To do this, it needs to keep track whether an address originated from a process or a file. It currently distinguishes addresses by setting an unused high bit on the address, but because of pointer authentication this is not a reliable solution. In order to keep this optimization working, this patch adds an extra opaque AddressSpace field to RemoteAddress, which LLDB can use on its own implementation of MemoryReader to distinguish between addresses. This patch is NFC for the other RemoteInspection clients, as it adds extra information to RemoteAddress, which is entirely optional and if unused should not change the behavior of the library. Although this patch is quite big the changes are largely mechanical, replacing threading StoredPointer with RemoteAddress. rdar://148361743
augusto2112
force-pushed
the
change-remote-addr
branch
from
e6d807a to
58df553
Compare
1 similar comment
|
@augusto2112 Could this PR have broken the build here? https://ci.swift.org/job/swift-PR-Linux-smoke-test/21185/console |
There's an accompanying LLDB PR (swiftlang/llvm-project#10928). The CI job probably picked up this commit but not the LLDB commit. It just started a new job which I assume should be fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an extra opaque field to AddressSpace, which can be used by clients
of RemoteInspection to distinguish between different address spaces.
LLDB employs an optimization where it reads memory from files instead of
the running process whenever it can to speed up memory reads (these can
be slow when debugging something over a network). To do this, it needs
to keep track whether an address originated from a process or a file. It
currently distinguishes addresses by setting an unused high bit on the
address, but because of pointer authentication this is not a reliable
solution. In order to keep this optimization working, this patch adds an
extra opaque AddressSpace field to RemoteAddress, which LLDB can use on
its own implementation of MemoryReader to distinguish between addresses.
This patch is NFC for the other RemoteInspection clients, as it adds
extra information to RemoteAddress, which is entirely optional and if
unused should not change the behavior of the library.
Although this patch is quite big the changes are largely mechanical,
replacing threading StoredPointer with RemoteAddress.
rdar://148361743