[RemoteMirrors] Fix losing the remote address on StaticMirror #82981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
etcwilde
reviewed
Jul 11, 2025
| @@ -5,7 +5,6 @@ | |||
| // | |||
| // Temporarily disable on AArch64 Linux (rdar://88451721) | |||
| // UNSUPPORTED: OS=linux-gnu && CPU=aarch64 | |||
There was a problem hiding this comment.
Do we still need this marked as unsupported on Linux?
There was a problem hiding this comment.
That one seems unrelated to this change.
There was a problem hiding this comment.
Adrian claimed this test was now passing on linux AArch64, hence Evan's question.
| @@ -10,7 +10,6 @@ | |||
|
|
|||
| // FIXME: rdar://127796117 | |||
| // UNSUPPORTED: OS=linux-gnu && CPU=aarch64 | |||
There was a problem hiding this comment.
Do we still need this marked as unsupported on Linux?
There was a problem hiding this comment.
Same passing claim as above, can probably be checked by enabling them and running the linux AArch64 CI on this pull.
There was a problem hiding this comment.
Ok, I removed it, lets see if it works
augusto2112
force-pushed
the
fix-remote-mirr
branch
from
57f3a64 to
3c331fc
Compare
|
@swift-ci smoke test |
mikeash
approved these changes
Jul 11, 2025
|
I can confirm applying this locally also fixes those two tests in my setup. Thanks! |
|
@swift-ci please build toolchain Ubuntu 22.04 aarch64 |
|
Swift Build Toolchain Ubuntu 22.04 (aarch64) Failure: |
|
I don't think that failure is related to this change |
I agree. Just had a script watch the PR for failed builds and extract failures for documenting purposes. |
|
@swift-ci please build toolchain UBI9 aarch64 |
That's a useful script! |
@etcwilde did this work? I don't see it running |
|
Yeah, I'm not sure we have a trigger for aarch64 UBI9. Was worth a try. |
The Offset field of a DynamicRelocation is either an offset or a remote address, but was being treated only as a remote address on getDynamicSymbol.
augusto2112
force-pushed
the
fix-remote-mirr
branch
from
3c331fc to
b6ce889
Compare
|
@swift-ci smoke test |
|
I want to cherry-pick this into 6.2, so to play it safe, I'll keep those tests unsupported in this PR, and open a separate PR reenabling those tests after this is merged. |
|
@swift-ci smoke test Windows |
There is a UBI 9 aarch64 CI job, so it would flag the issue once committed, if this still didn't work. Not sure about manual pre-commit CI triggers though, is there a list somewhere public? The official doc is way behind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Offset field of a DynamicRelocation is either an offset or a remote address, but was being treated only as a remote address on getDynamicSymbol.