[6.2][android] Small test and build tweaks #82986
Open
+22
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix two IRGen tests that are failing on Android armv7 and disable eight ClangImporter, C++ Interop, and SILOptimizer tests, two of which that were already failing on other 32-bit platforms.
…wiftlang#82620) I just noticed the install issue when cross-compiling Testing with a freshly-built compiler, which I'd never done before. Also, fix the NDK path shown in the CMake output.
finagolfin
changed the title
finagolfin
added
🍒 release cherry pick
|
@swift-ci smoke test |
|
@swift-ci test linux |
|
@swift-ci test macos |
|
@bnbarham, mind reviewing this small pull? |
bnbarham
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Disable several tests for Android armv7 and add some build config for cross-compiling the corelibs, fixing the libcurl build, and installing a cross-compiled toolchain.
Scope: Tweak some tests and add cross-compilation build config
Issue: #80788
Original PR: #82501, non-test changes from #82620, #82924
Risk: Very low, tests were only loosened or disabled for Android and this cross-compilation build config is not run on any official CI yet.
Testing: Passed CI and we're using these patches in preliminary builds of an official Android CI job, which uses these changes to pass the full compiler validation suite and produce an Android SDK bundle
Reviewer: @etcwilde
The Swift core team tasked the Swift on Android workgroup with putting together an official 6.2 Android CI job, so @marcprux and I have been piecing together a pull for that, swiftlang/swift-docker#467, and these are more of the trunk patches we had to backport to 6.2 so far. Once the remaining patches there have been reworked and merged to trunk, I will submit another 6.2 pull later on with those final patches.