[Dependency Scanning] Restrict Swift overlay lookup to "visible" Clang modules only #83050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
cachemeifyoucan,
hborla,
slavapestov,
xedin and
xymus
as code owners
|
@swift-ci test |
cyndyishida
reviewed
Jul 14, 2025
1 similar comment
artemcm
force-pushed
the
AdoptVisibleClangModulesForOverlayDiscovery
branch
from
1c73538 to
5600184
Compare
artemcm
force-pushed
the
AdoptVisibleClangModulesForOverlayDiscovery
branch
from
5600184 to
b38ca14
Compare
|
swiftlang/llvm-project#10987 |
|
swiftlang/llvm-project#10987 |
|
I am seeing CI hit failures in: and Intermittently. I haven't been able to reproduce them locally yet but I suspect there's a memory bug here somewhere. |
…ngTool::getModuleDependencies'
…g modules only Previously Swift overlay lookup was performed for every directly and transitively-imported Clang module. llvm/llvm-project#147969 introduced the concept of "visible" Clang modules from a given named Clang dependency scanner query which closely maps to the set of modules for which Swift will attempt to load a Swift overlay. This change switches overlay querying to apply only to the set of such visible modules. Resolves rdar://144797648
…ft modules are always queried by-name to the Clang dependency scanner This is required in order to always have computed the set of visible Clang modules for each Swift module in the graph. Otherwise when some Clang module gets cached as a transitive dependency from a query and is later looked up as a direct dependency, there will not be any computed visible modules set.
artemcm
force-pushed
the
AdoptVisibleClangModulesForOverlayDiscovery
branch
from
b38ca14 to
27305d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project#147969 added support to the Clang dependency scanner to query the set of "visible" modules for a given TU or named query. Swift must utilize this data to driver lookup of Swift module overlays. Previously, the scanner implementation queried Swift module overlay dependencies for a Swift module by checking all of its imported Clang modules, direct and transitive - even when not re-exported. With this change, the scanner's overlay lookup is only done for a Swift module's "visible" set of Clang module dependencies as reported by the scanner, matching the behavior expected to occur in the subsequent compilation task.