Skip to content

FreeBSD: Fix issues in tests #83106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2025

Conversation

etcwilde
Copy link
Member

This patch fixes a few issues in existing tests.

  • The SIMD module is only available on Apple platforms so marking the SIMD test as unsupported on FreeBSD.
  • pthreads are declared and imported differently on FreeBSD compared to Linux. Fixing how they are passed through the tsan tests.
  • Fixing a change in behavior in the lld function_sections test

etcwilde added 3 commits July 16, 2025 11:01
The SIMD module is not available on FreeBSD, disabling it.
Fixing pthread usage in tsan and tsan-inout tests. pthreads are imported
as opaque pointers on FreeBDS, and thus need to be kept in an optional
pthread_t, like on Apple platforms.

Unlike on macOS, pthread_join is not annotated with nullability
annotations and thus takes an optional opaque pointer, so we don't need
to unwrap it.
Newer versions of lld are keeping the unused function section for func2,
causing this test to fail.
@etcwilde etcwilde requested a review from al45tair July 16, 2025 18:23
@etcwilde etcwilde self-assigned this Jul 16, 2025
@etcwilde etcwilde requested a review from a team as a code owner July 16, 2025 18:23
@etcwilde etcwilde added the FreeBSD Platform: FreeBSD label Jul 16, 2025
@etcwilde
Copy link
Member Author

@swift-ci please test

@etcwilde etcwilde moved this to In Progress in Swift on FreeBSD Jul 16, 2025
@etcwilde etcwilde merged commit 22f32e0 into swiftlang:main Jul 17, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Swift on FreeBSD Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FreeBSD Platform: FreeBSD
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants