-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Diagnose @_lifetime on targets that are Escapable #83111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci smoke test |
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@swift-ci test |
Lifetime dependencies can be attached to ~Escapable types only
d59616e
to
c8defec
Compare
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple more questions/asks about tests but otherwise looks good!
ec84366
to
d7b7fba
Compare
@swift-ci test |
@@ -128,23 +126,6 @@ func noescapeMutOpt(_ ptr: UnsafeMutablePointer<CInt>?) -> UnsafeMutablePointer< | |||
// CHECK-NEXT: }() | |||
// CHECK-NEXT: } | |||
|
|||
// CHECK: @_alwaysEmitIntoClient @_lifetime(copy ptr) @_disfavoredOverload | |||
// CHECK-NEXT: func noescapeOpt(_ ptr: Span<CInt>?) -> UnsafePointer<CInt>? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no longer any overload generated for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this no longer exists.
@swift-ci test |
@swift-ci test |
No description provided.