[Store] Add support for Redis #269
Conversation
carsonbot
added
Feature
| ->useAttributeAsKey('name') | ||
| ->arrayPrototype() | ||
| ->children() | ||
| ->variableNode('connection_parameters') |
There was a problem hiding this comment.
what about going with a DSN here instead? For Symfony cache we use REDIS_URL etc. this way we can just reuse an existing Redis connection
There was a problem hiding this comment.
Would be nice indeed.
But Symfony cache has a huge amount of code to parse the the DSN.
I don't want to bloat the the store for now
There was a problem hiding this comment.
It's good that the RedisStore only takes an instance of Redis. It is not its responsibility to instantiate the Redis client.
The bundle configuration should accept a redis service name, which could be created directly in the application or with SncRedisBundle (which accepts dsn in config).
|
Could you bring in a rag example as well, please? redis cloud or docker compose maybe |
|
docker compose if possible please 🙏 |
I continue to bench different store, and the next one is Redis