[auth] Inject UrlGeneratorInterface instead of RouterInterface #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Jan 16, 2019
|
1/ should i keep or remove my commit regarding CS fixes ? |
|
Thanks Rémi! No worries about the cs stuff - it's fine. And tests were fixed in another PR - was unrelated to your work :) |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 24, 2019
… (romaricdrigon) This PR was submitted for the 4.2 branch but it was merged into the 4.1 branch instead (closes #10925). Discussion ---------- MakerBundle v1.11.13 uses urlGenerator instead of Router Hello, Since version 1.11.3 and PR [#349](symfony/maker-bundle#349) MakerBundle uses `UrlGeneratorInterface` instead of `RouterInterface` when generating a new Guard for a login form, and the corresponding property changed. Hence the documentation code snippet is misleading. I'm not totally sure of which branch to PR on; being a change from latest version of MakerBundle, I think this is especially important for new projects, so using the latest Symfony version. Commits ------- f00344a MakerBundle uses urlGenerator instead of Router
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.