Skip to content

Add TraceablePublisher #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Add TraceablePublisher #15

wants to merge 0 commits into from

Conversation

vincentchalamon
Copy link
Contributor

@vincentchalamon vincentchalamon commented Nov 5, 2019 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1, #12
  • Implement TraceablePublisher
  • Add PublisherInterface for autowiring
  • Write TraceablePublisherTest

@vincentchalamon vincentchalamon mentioned this pull request Nov 5, 2019
Closed
6 tasks
dunglas
dunglas reviewed Nov 5, 2019
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests will be added!

@vincentchalamon vincentchalamon changed the title [WIP] Add TraceablePublisher Add TraceablePublisher Nov 5, 2019
@vincentchalamon vincentchalamon force-pushed the master branch 2 times, most recently from b6eaf29 to 47a3462 Compare November 5, 2019 18:25
@dunglas
Copy link
Member

dunglas commented Nov 6, 2019

Also close #12

@dunglas dunglas closed this Nov 7, 2019
@dunglas dunglas mentioned this pull request Nov 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentchalamon @dunglas