Skip to content

Add Mbstring::assertEncoding() #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

zonuexe
Copy link
Contributor

@zonuexe zonuexe commented Mar 31, 2024

The same pattern of encoding checks is required in another method, so you can separate encoding assertions and avoid copy-pasting.

refs https://github.com/symfony/polyfill/pull/466/files#r1545573878 Cc: @Ayesh

@nicolas-grekas
Copy link
Member

Rebase welcome now that #466 is merged.

@zonuexe zonuexe force-pushed the refactor/assertEncoding branch from c250b12 to f5abc49 Compare April 12, 2024 10:23
@zonuexe
Copy link
Contributor Author

zonuexe commented Apr 12, 2024

@nicolas-grekas Thanks, I applied this method to other methods as well and pushed it.

@nicolas-grekas
Copy link
Member

Thank you @zonuexe.

@nicolas-grekas nicolas-grekas merged commit 8a4bd23 into symfony:1.x Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants