Skip to content

Add Octopush notifier transport #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Jan 15, 2021
Merged

Add Octopush notifier transport #870

1 commit merged into from
Jan 15, 2021

Conversation

aurelienmartin
Copy link

@aurelienmartin aurelienmartin commented Jan 8, 2021 •
edited
Loading

Q A
License MIT
Doc issue/PR symfony/symfony#39702

ghost
ghost suggested changes Jan 8, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

ghost
ghost suggested changes Jan 8, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

symfony/octopush-notifier/5.3/manifest.json Outdated
"env": {
"#1": "OCTOPUSH_DSN=octopush://USERLOGIN:APIKEY@default?from=FROM&type=TYPE"
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should end with a newline

ghost
ghost suggested changes Jan 8, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

ghost
ghost suggested changes Jan 8, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request does not pass validation.

@aurelienmartin aurelienmartin mentioned this pull request Jan 8, 2021
Merged
OskarStark added a commit to symfony/symfony that referenced this pull request Jan 14, 2021
@OskarStark
feature #39702 [Notifier] Add Octopush notifier transport (aurelienhe…
f2ba203 
…yliot)

This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] Add Octopush notifier transport

| Q             | A
| ------------- | ---
| Branch?       | 5.x
| Bug fix?      | no
| New feature?  | yes <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no
| License       | MIT
| Doc PR        | symfony/symfony-docs#14779 <!-- required for new features -->
| Recipe PR| symfony/recipes#870

Commits
-------

93dde15 Add Octopush notifier transport
@fabpot
Copy link
Member

fabpot commented Jan 15, 2021

@symfony-flex-server review again please

ghost
ghost approved these changes Jan 15, 2021
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@ghost ghost merged commit eb51fde into symfony:master Jan 15, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aurelienmartin @fabpot @OskarStark @aurelienheyliot