[attributes.add()] the Add() need to have an example and clarificati… #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of usage and how to used the [attributes.add()] need to have an example and clarification of usage and how to used and why it should be used
weaverryan
reviewed
May 18, 2023
| @@ -601,6 +601,8 @@ Set an attribute's value to ``false`` to exclude the attribute: | |||
|
|
|||
| .. versionadded:: 2.7 | |||
|
|
|||
| #this part needs more calrification and an example of how to use it and why | |||
|
|
|||
There was a problem hiding this comment.
The purpose of the add() method is to be able to render a Stimulus controller on your root component element. We mention it below. Do you have a suggestion about how it could be more clear?
There was a problem hiding this comment.
just give more example like for beginners they would not know what are the Stimulus controller
|
you can jsut add this link to let beginners know about the Stimulus javascript framwork https://symfony.com/doc/current/frontend/encore/simple-example.html#stimulus-symfony-ux |
|
Thanks for the clarification - I've added it over on #887 Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on of usage and how to used
the [attributes.add()] need to have an example and clarification of usage and how to used and why it should be used