-
Notifications
You must be signed in to change notification settings - Fork 136
SSA optimizer enhancements #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jserv
wants to merge
6
commits into
master
Choose a base branch
from
improve-ssa
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+592
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrXiao
reviewed
Aug 13, 2025
a8695c2
to
9ecf518
Compare
- Add comprehensive constant folding for arithmetic, bitwise, logical, and comparison operations - Include zero-division protection for division and modulo operations - Add unary operation constant folding (negate, bit_not, log_not)
- Implement SCCP (Sparse Conditional Constant Propagation) optimization pass - Add constant propagation through assignments - Add constant folding for arithmetic and comparison operations - Add branch folding when conditions are compile-time constants - Include dead code elimination through unreachable branch removal
- Replace magic numbers with configuration constants (PHI_WORKLIST_SIZE, DCE_WORKLIST_SIZE) - Add overflow protection for PHI worklist to prevent buffer overruns - Improve safety checks in dead code elimination
- Add comprehensive CSE support for arithmetic, bitwise, logical, and comparison operations - Support commutative operation detection (add, mul, and, or, xor, eq, neq) - Maintain existing array access pattern optimization (add + read) - Add safety checks to prevent CSE with global variables
- Add unreachable block detection using dominator analysis - Implement conservative dead store elimination for immediate overwrites - Add redundant assignment elimination (x = x patterns) - Enhance DCE worklist algorithm with better bounds checking - Simplify escape analysis to be maximally conservative - Add instruction elimination metrics tracking - Fix phi operand marking in DCE worklist processing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the SSA optimization framework with multiple optimization techniques that operate at the basic block level:
Summary by Bito
This pull request enhances the SSA optimization framework with multiple techniques at the basic block level, including Sparse Conditional Constant Propagation, improved constant folding, and Common Subexpression Elimination. Additionally, error handling has been refactored for better robustness, aiming to optimize performance and efficiency.