Discard invalid variants and utilities with modifiers
#13977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
fix/discard-invalid-modifiers
branch
from
aacb7b5 to
0a06fa6
Compare
thecrypticace
approved these changes
Jul 10, 2024
RobinMalfait
force-pushed
the
fix/discard-invalid-modifiers
branch
from
6565b49 to
5d014c0
Compare
Right now, `bg-red-1/2/3` should not parse
RobinMalfait
force-pushed
the
fix/discard-invalid-modifiers
branch
from
5d014c0 to
fa3e523
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR discards candidates that contain modifiers for variants and utilities that don't need it.
For example, right now you can use
hover/foo:flexor evenflex/foo. These generate the exact same contents ashover:flexandflexrespectively. However, thefoomodifier isn't used but is still included in the class name, which means that this currently just generates additional unnecessary CSS.For static utilities and static variants, we can bail early when we detect a modifier and we don't have to continue parsing the candidate. We also don't have to run the known invalid candidate through the system. (In theory if you have a lot of invalid candidates like this it will result in better performance and smaller CSS)
Some utilities and variants accept modifiers, e.g.:
bg-red-500/50orgroup-hover/foo. In these cases we can't discard themodifierautomatically, which is why the PR is relatively big because we have to discard on a case by case basis.Requires:
bg-red-[#000]#13970