Skip to content

ci: fix http dependency in tests #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

ylobankov
Copy link
Contributor

@ylobankov ylobankov commented Oct 29, 2021

At this moment http dependency in tests is broken since we are trying
to install the http 2.1.0 lua rock. Now this rock is not available
anymore due to tarantool/http#142 and that is the reason for test
failures with the following error:

http not found for Lua 5.1.
Error: No results matching query were found for Lua 5.1.
Checking if available for other Lua versions...
make: *** [Makefile:10: .rocks] Error 1
Checking for Lua 5.2...
Checking for Lua 5.3...
Checking for Lua 5.4...
Error: Process completed with exit code 2.

Now http v2 is available under the http-v2-legacy lua rock and this
patch switches the use of http 2.1.0 to http-v2-legacy 2.1.0.

Manual test run with http-v2-legacy 2.1.0.

@Totktonada
Copy link
Member

The http v2 still available, but is not recommended. I suggest to use v1.

$ tarantoolctl rocks search http

http - Search results for Lua 5.1:
==================================


Rockspecs and source rocks:
---------------------------

http
   scm-1 (rockspec) - http://rocks.tarantool.org
   1.1.1-1 (rockspec) - http://rocks.tarantool.org
   1.1.1-1 (src) - http://rocks.tarantool.org
   1.1.0-1 (rockspec) - http://rocks.tarantool.org
   1.0.6-1 (rockspec) - http://rocks.tarantool.org
   1.0.5-1 (rockspec) - http://rocks.tarantool.org
   1.0.4-1 (rockspec) - http://rocks.tarantool.org
   1.0.3-1 (rockspec) - http://rocks.tarantool.org
   1.0.2-1 (rockspec) - http://rocks.tarantool.org
   1.0.1-1 (rockspec) - http://rocks.tarantool.org

http-v2-legacy
   2.1.0-1 (rockspec) - http://rocks.tarantool.org
   2.0.1-1 (rockspec) - http://rocks.tarantool.org
   2.0.0-1 (rockspec) - http://rocks.tarantool.org

@ylobankov ylobankov force-pushed the ylobankov/fix-http-dependency-in-tests branch 2 times, most recently from dcb3db3 to 6bc863d Compare October 29, 2021 14:28
At this moment http dependency in tests is broken since we are trying
to install the `http 2.1.0` lua rock. Now this rock is not available
anymore due to tarantool/http#142 and that is the reason for test
failures with the following error:

    http not found for Lua 5.1.
    Error: No results matching query were found for Lua 5.1.
    Checking if available for other Lua versions...
    make: *** [Makefile:10: .rocks] Error 1
    Checking for Lua 5.2...
    Checking for Lua 5.3...
    Checking for Lua 5.4...
    Error: Process completed with exit code 2.

Now http v2 is available under the `http-v2-legacy` lua rock and this
patch switches the use of `http 2.1.0` to `http-v2-legacy 2.1.0`.
@ylobankov ylobankov force-pushed the ylobankov/fix-http-dependency-in-tests branch from 6bc863d to 2d2d86b Compare October 29, 2021 14:45
@yngvar-antonsson yngvar-antonsson merged commit da40cd4 into master Oct 29, 2021
@yngvar-antonsson yngvar-antonsson deleted the ylobankov/fix-http-dependency-in-tests branch October 29, 2021 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants