Skip to content

Support arm64 runners and fix caching #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/actions/latest-version/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ outputs:
abc-d:
description: 'Latest tarantool version in the A.B.C-D form'
value: ${{ steps.get-latest-version.outputs.abc-d }}
# Tarantool 3.x has no git commit id in the package version, so
# the git-describe output have no sense for 3.x.
git-describe:
description: 'Latest tarantool version in the A.B.C-D-gHHHHHHHHH form'
value: ${{ steps.get-latest-version.outputs.git-describe }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/test-docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ jobs:
image:
- ubuntu:focal
- ubuntu:jammy
- debian:buster
- debian:bullseye

include:
Expand Down
57 changes: 29 additions & 28 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,28 +8,20 @@ jobs:
strategy:
fail-fast: false
matrix:
runs-on: [ubuntu-20.04]
runs-on: [ubuntu-22.04]
tarantool:
- '1.10'
- '2.4'
- '2.5'
- '2.6'
- '2.7'
- '2.8'
- '2.9'
- '2.10'
- '2.11'
- '3.0'
- '3.1'
- '3.2'
- '3.3'
- '3.4'
nightly: [false]
include:
# We have Ubuntu Jammy (22.04) packages only for 2.10 at
# the moment of adding this code. There is commit
# 1.10.13-9-g2d23c9d9c, but 1.10.14 is not released yet.
# And there is some infrastructure problem with Jammy
# packages in the live/1.10 repository.
#
# Anyway, 2.10 is okay to test the action of Jammy runner,
# so just use it.
- {runs-on: ubuntu-22.04, tarantool: '2.10', nightly: false}
- {runs-on: ubuntu-20.04, tarantool: '1.10', nightly: true}
# Nightly build test.
- {runs-on: ubuntu-22.04, tarantool: '1.10', nightly: true}
runs-on: ${{ matrix.runs-on }}
env:
TARANTOOL_CACHE_KEY_SUFFIX: -A-${{ github.run_id }}
Expand All @@ -50,7 +42,7 @@ jobs:

- uses: ./.github/actions/verify-version
with:
tarantool-version: '${{ steps.latest-version.outputs.git-describe }}'
tarantool-version: '${{ steps.latest-version.outputs.abc }}'
from-cache: false

- name: Uninstall tarantool
Expand All @@ -64,14 +56,20 @@ jobs:

- uses: ./.github/actions/verify-version
with:
tarantool-version: '${{ steps.latest-version.outputs.git-describe }}'
tarantool-version: '${{ steps.latest-version.outputs.abc }}'
from-cache: true

test-concurrency:
strategy:
fail-fast: false
matrix:
runs-on: [ubuntu-20.04, ubuntu-20.04, ubuntu-20.04]
runs-on:
- ubuntu-24.04
- ubuntu-24.04
- ubuntu-24.04
- ubuntu-24.04-arm
- ubuntu-24.04-arm
- ubuntu-24.04-arm
runs-on: ${{ matrix.runs-on }}
env:
TARANTOOL_CACHE_KEY_SUFFIX: -B-${{ github.run_id }}
Expand All @@ -80,7 +78,7 @@ jobs:
- name: Setup Tarantool
uses: ./
with:
tarantool-version: '1.10'
tarantool-version: '2.11'

# This test case performs basic test of the three digit version
# support.
Expand All @@ -95,7 +93,7 @@ jobs:
# - install 1.10.LATEST
# - checks: version, non-cached
test-exact-version-basic:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
env:
TARANTOOL_CACHE_KEY_SUFFIX: -C-${{ github.run_id }}
steps:
Expand Down Expand Up @@ -152,7 +150,7 @@ jobs:
# - install 1.10
# - checks: version, non-cached
test-exact-version-then-two-digit-version:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
env:
TARANTOOL_CACHE_KEY_SUFFIX: -D-${{ github.run_id }}
steps:
Expand Down Expand Up @@ -198,7 +196,7 @@ jobs:
# - install 1.10
# - checks: version, cached
test-exact-version-latest-then-two-digit-version:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
env:
TARANTOOL_CACHE_KEY_SUFFIX: -E-${{ github.run_id }}
steps:
Expand Down Expand Up @@ -245,7 +243,7 @@ jobs:
# - install 1.10 (nightly)
# - checks: version, cached
test-exact-version-nightly:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
env:
TARANTOOL_CACHE_KEY_SUFFIX: -F-${{ github.run_id }}
steps:
Expand Down Expand Up @@ -296,6 +294,8 @@ jobs:
# This test case installs tarantool of series-2 and series-3
# using one/two/three digit version specifier.
#
# Runs on amd64 and arm64 architecture.
#
# It performs the following steps and checks.
#
# - install tarantool
Expand All @@ -309,12 +309,13 @@ jobs:
matrix:
tarantool:
- '2'
- '2.10'
- '2.10.0'
- '2.11'
- '2.11.7'
- '3'
- '3.0'
- '3.0.0'
runs-on: ubuntu-latest
runs-on: [ubuntu-24.04, ubuntu-24.04-arm]
runs-on: ${{ matrix.runs-on }}
env:
# github.run_id is the same across different jobs created
# from the same matrix.
Expand Down
9 changes: 9 additions & 0 deletions HACKING.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,12 @@ Edit the source and regenerate the `index.js` file.
$ vim src/main.ts
$ npm run pre-checkin
```

## Update dependencies

```shell
$ npx npm-check-updates -u
$ npm install
$ npm update
$ npm run pre-checkin
```
Loading
Loading